You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Thomas Neidhart (JIRA)" <ji...@apache.org> on 2013/02/07 18:03:12 UTC

[jira] [Resolved] (COLLECTIONS-312) Minor changes to tidy modifiers for fields, methods and classes.

     [ https://issues.apache.org/jira/browse/COLLECTIONS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Neidhart resolved COLLECTIONS-312.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0

Applied remaining changes from patch in r1443602.

Did not touch the simplifications for equals methods as this may collide with findbugs / checkstyle, as well as some string concatenations.
                
> Minor changes to tidy modifiers for fields, methods and classes.
> ----------------------------------------------------------------
>
>                 Key: COLLECTIONS-312
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-312
>             Project: Commons Collections
>          Issue Type: Improvement
>            Reporter: Peter Lawrey
>            Priority: Trivial
>             Fix For: 4.0
>
>         Attachments: commons-collections-static-analysis.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> These changes include
> - private/package-local fields final if possible.
> - private/package-local methods and classes static if possible
> - remove fields which can be make local variables.
> See the attached patch for the changes

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira