You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by Attila Magyar <am...@hortonworks.com> on 2017/11/23 15:31:22 UTC

Review Request 64050: Ambari UI changes to support Isilon OneFS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64050/
-----------------------------------------------------------

Review request for Ambari, Alexandr Antonenko, Andrii Tkach, and Nate Cole.


Bugs: AMBARI-22507
    https://issues.apache.org/jira/browse/AMBARI-22507


Repository: ambari


Description
-------

This change separates hdfs compatible file systems from the rest of the services on the UI, and makes sure that one DFS can be selected at a time.


Diffs
-----

  ambari-web/app/controllers/wizard/step4_controller.js 8a62f3b 
  ambari-web/app/mappers/stack_service_mapper.js f49b4d0 
  ambari-web/app/messages.js 9ca51de 
  ambari-web/app/models/stack_service.js a84816e 
  ambari-web/app/templates/wizard/step4.hbs 5a08250 
  ambari-web/test/controllers/wizard/step4_test.js 1cd4863 


Diff: https://reviews.apache.org/r/64050/diff/1/


Testing
-------

- tested with isilon mpack, 2 dfs: ONEFS, HDFS
- tested without isilon, 1 dfs: HDFS


ambari-web tests: passed


Thanks,

Attila Magyar

Re: Review Request 64050: Ambari UI changes to support Isilon OneFS

Posted by Andrii Tkach <at...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64050/#review191799
-----------------------------------------------------------


Ship it!




Ship It!

- Andrii Tkach


On Nov. 23, 2017, 3:31 p.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64050/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2017, 3:31 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, and Nate Cole.
> 
> 
> Bugs: AMBARI-22507
>     https://issues.apache.org/jira/browse/AMBARI-22507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This change separates hdfs compatible file systems from the rest of the services on the UI, and makes sure that one DFS can be selected at a time.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step4_controller.js 8a62f3b 
>   ambari-web/app/mappers/stack_service_mapper.js f49b4d0 
>   ambari-web/app/messages.js 9ca51de 
>   ambari-web/app/models/stack_service.js a84816e 
>   ambari-web/app/templates/wizard/step4.hbs 5a08250 
>   ambari-web/test/controllers/wizard/step4_test.js 1cd4863 
> 
> 
> Diff: https://reviews.apache.org/r/64050/diff/1/
> 
> 
> Testing
> -------
> 
> - tested with isilon mpack, 2 dfs: ONEFS, HDFS
> - tested without isilon, 1 dfs: HDFS
> 
> 
> ambari-web tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 64050: Ambari UI changes to support Isilon OneFS

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64050/#review192059
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On Nov. 23, 2017, 10:31 a.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64050/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2017, 10:31 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, and Nate Cole.
> 
> 
> Bugs: AMBARI-22507
>     https://issues.apache.org/jira/browse/AMBARI-22507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This change separates hdfs compatible file systems from the rest of the services on the UI, and makes sure that one DFS can be selected at a time.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step4_controller.js 8a62f3b 
>   ambari-web/app/mappers/stack_service_mapper.js f49b4d0 
>   ambari-web/app/messages.js 9ca51de 
>   ambari-web/app/models/stack_service.js a84816e 
>   ambari-web/app/templates/wizard/step4.hbs 5a08250 
>   ambari-web/test/controllers/wizard/step4_test.js 1cd4863 
> 
> 
> Diff: https://reviews.apache.org/r/64050/diff/1/
> 
> 
> Testing
> -------
> 
> - tested with isilon mpack, 2 dfs: ONEFS, HDFS
> - tested without isilon, 1 dfs: HDFS
> 
> 
> ambari-web tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 64050: Ambari UI changes to support Isilon OneFS

Posted by Attila Magyar <am...@hortonworks.com>.


> On Nov. 27, 2017, 3:41 p.m., Nate Cole wrote:
> > ambari-web/app/mappers/stack_service_mapper.js
> > Lines 122-124 (patched)
> > <https://reviews.apache.org/r/64050/diff/1/?file=1900652#file1900652line122>
> >
> >     HDFS should also have its type as HCFS, no?  meaning, can we only EVER check for service_type === HCFS?

Yes, HDFS is HCFS. I want to unselect every HCFS except HDFS by default. All of the other services are also selected by default, but selecting all HCFS wouldn't be valid.


- Attila


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64050/#review191896
-----------------------------------------------------------


On Nov. 23, 2017, 3:31 p.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64050/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2017, 3:31 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, and Nate Cole.
> 
> 
> Bugs: AMBARI-22507
>     https://issues.apache.org/jira/browse/AMBARI-22507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This change separates hdfs compatible file systems from the rest of the services on the UI, and makes sure that one DFS can be selected at a time.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step4_controller.js 8a62f3b 
>   ambari-web/app/mappers/stack_service_mapper.js f49b4d0 
>   ambari-web/app/messages.js 9ca51de 
>   ambari-web/app/models/stack_service.js a84816e 
>   ambari-web/app/templates/wizard/step4.hbs 5a08250 
>   ambari-web/test/controllers/wizard/step4_test.js 1cd4863 
> 
> 
> Diff: https://reviews.apache.org/r/64050/diff/1/
> 
> 
> Testing
> -------
> 
> - tested with isilon mpack, 2 dfs: ONEFS, HDFS
> - tested without isilon, 1 dfs: HDFS
> 
> 
> ambari-web tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 64050: Ambari UI changes to support Isilon OneFS

Posted by Nate Cole <nc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64050/#review191896
-----------------------------------------------------------




ambari-web/app/mappers/stack_service_mapper.js
Lines 122-124 (patched)
<https://reviews.apache.org/r/64050/#comment269833>

    HDFS should also have its type as HCFS, no?  meaning, can we only EVER check for service_type === HCFS?


- Nate Cole


On Nov. 23, 2017, 10:31 a.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64050/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2017, 10:31 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, and Nate Cole.
> 
> 
> Bugs: AMBARI-22507
>     https://issues.apache.org/jira/browse/AMBARI-22507
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This change separates hdfs compatible file systems from the rest of the services on the UI, and makes sure that one DFS can be selected at a time.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step4_controller.js 8a62f3b 
>   ambari-web/app/mappers/stack_service_mapper.js f49b4d0 
>   ambari-web/app/messages.js 9ca51de 
>   ambari-web/app/models/stack_service.js a84816e 
>   ambari-web/app/templates/wizard/step4.hbs 5a08250 
>   ambari-web/test/controllers/wizard/step4_test.js 1cd4863 
> 
> 
> Diff: https://reviews.apache.org/r/64050/diff/1/
> 
> 
> Testing
> -------
> 
> - tested with isilon mpack, 2 dfs: ONEFS, HDFS
> - tested without isilon, 1 dfs: HDFS
> 
> 
> ambari-web tests: passed
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>