You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/05/02 10:14:31 UTC
Review Request: CLOUDSTACK-2188: Parsing error with Download Monitor while
checking the health of downloaded templates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10901/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
Description
-------
CLOUDSTACK-2188 : Parsing error with Download Monitor while checking the health of downloaded templates.
This addresses bug CLOUDSTACK-2188.
Diffs
-----
server/src/com/cloud/storage/download/DownloadMonitorImpl.java 5d7a210
Diff: https://reviews.apache.org/r/10901/diff/
Testing
-------
Tested on my local CloudStack setup.
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUDSTACK-2188: Parsing error with Download Monitor
while checking the health of downloaded templates
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10901/#review20111
-----------------------------------------------------------
server/src/com/cloud/storage/download/DownloadMonitorImpl.java
<https://reviews.apache.org/r/10901/#comment41363>
Change looks fine. Can you also add a comment explaining why the check is needed?
- Devdeep Singh
On May 2, 2013, 10:16 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10901/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 10:16 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> CLOUDSTACK-2188 : Parsing error with Download Monitor while checking the health of downloaded templates.
>
>
> This addresses bug CLOUDSTACK-2188.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/download/DownloadMonitorImpl.java 5d7a210
>
> Diff: https://reviews.apache.org/r/10901/diff/
>
>
> Testing
> -------
>
> Tested on my local CloudStack setup.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2188: Parsing error with Download Monitor
while checking the health of downloaded templates
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10901/#review20189
-----------------------------------------------------------
Commit e56d2a401c40b4208d062c0a0ce1ec01df73dd08 in branch refs/heads/vmware-datamodel from Sateesh Chodapuneedi <sa...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e56d2a4 ]
CLOUDSTACK-2188 : Parsing error with Download Monitor while checking the health of downloaded templates
Signed-off-by: Sateesh Chodapuneedi <sa...@apache.org>
- ASF Subversion and Git Services
On May 3, 2013, 11:30 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10901/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 11:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> CLOUDSTACK-2188 : Parsing error with Download Monitor while checking the health of downloaded templates.
>
>
> This addresses bug CLOUDSTACK-2188.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/download/DownloadMonitorImpl.java 5d7a210
>
> Diff: https://reviews.apache.org/r/10901/diff/
>
>
> Testing
> -------
>
> Tested on my local CloudStack setup.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2188: Parsing error with Download Monitor
while checking the health of downloaded templates
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10901/#review20188
-----------------------------------------------------------
Ship it!
Commit e56d2a401c40b4208d062c0a0ce1ec01df73dd08
- Sateesh Chodapuneedi
On May 3, 2013, 11:30 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10901/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 11:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> CLOUDSTACK-2188 : Parsing error with Download Monitor while checking the health of downloaded templates.
>
>
> This addresses bug CLOUDSTACK-2188.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/download/DownloadMonitorImpl.java 5d7a210
>
> Diff: https://reviews.apache.org/r/10901/diff/
>
>
> Testing
> -------
>
> Tested on my local CloudStack setup.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2188: Parsing error with Download Monitor
while checking the health of downloaded templates
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10901/#review20187
-----------------------------------------------------------
Commit e56d2a401c40b4208d062c0a0ce1ec01df73dd08 in branch refs/heads/master from Sateesh Chodapuneedi <sa...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e56d2a4 ]
CLOUDSTACK-2188 : Parsing error with Download Monitor while checking the health of downloaded templates
Signed-off-by: Sateesh Chodapuneedi <sa...@apache.org>
- ASF Subversion and Git Services
On May 3, 2013, 11:30 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10901/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 11:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> CLOUDSTACK-2188 : Parsing error with Download Monitor while checking the health of downloaded templates.
>
>
> This addresses bug CLOUDSTACK-2188.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/download/DownloadMonitorImpl.java 5d7a210
>
> Diff: https://reviews.apache.org/r/10901/diff/
>
>
> Testing
> -------
>
> Tested on my local CloudStack setup.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2188: Parsing error with Download Monitor
while checking the health of downloaded templates
Posted by Devdeep Singh <de...@citrix.com>.
> On May 6, 2013, 5:15 a.m., Devdeep Singh wrote:
> > Ship It!
A committer should pick this up and apply the changes.
- Devdeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10901/#review20175
-----------------------------------------------------------
On May 3, 2013, 11:30 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10901/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 11:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> CLOUDSTACK-2188 : Parsing error with Download Monitor while checking the health of downloaded templates.
>
>
> This addresses bug CLOUDSTACK-2188.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/download/DownloadMonitorImpl.java 5d7a210
>
> Diff: https://reviews.apache.org/r/10901/diff/
>
>
> Testing
> -------
>
> Tested on my local CloudStack setup.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2188: Parsing error with Download Monitor
while checking the health of downloaded templates
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10901/#review20175
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On May 3, 2013, 11:30 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10901/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 11:30 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> CLOUDSTACK-2188 : Parsing error with Download Monitor while checking the health of downloaded templates.
>
>
> This addresses bug CLOUDSTACK-2188.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/download/DownloadMonitorImpl.java 5d7a210
>
> Diff: https://reviews.apache.org/r/10901/diff/
>
>
> Testing
> -------
>
> Tested on my local CloudStack setup.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-2188: Parsing error with Download Monitor
while checking the health of downloaded templates
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10901/
-----------------------------------------------------------
(Updated May 3, 2013, 11:30 a.m.)
Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
Changes
-------
Added comment in the "if" condition check as per review comment.
Description
-------
CLOUDSTACK-2188 : Parsing error with Download Monitor while checking the health of downloaded templates.
This addresses bug CLOUDSTACK-2188.
Diffs (updated)
-----
server/src/com/cloud/storage/download/DownloadMonitorImpl.java 5d7a210
Diff: https://reviews.apache.org/r/10901/diff/
Testing
-------
Tested on my local CloudStack setup.
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUDSTACK-2188: Parsing error with Download Monitor
while checking the health of downloaded templates
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10901/
-----------------------------------------------------------
(Updated May 2, 2013, 10:16 a.m.)
Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
Changes
-------
Updated patch.
Description
-------
CLOUDSTACK-2188 : Parsing error with Download Monitor while checking the health of downloaded templates.
This addresses bug CLOUDSTACK-2188.
Diffs (updated)
-----
server/src/com/cloud/storage/download/DownloadMonitorImpl.java 5d7a210
Diff: https://reviews.apache.org/r/10901/diff/
Testing
-------
Tested on my local CloudStack setup.
Thanks,
Sanjay Tripathi