You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "dqhl76 (via GitHub)" <gi...@apache.org> on 2023/07/25 14:55:11 UTC
[GitHub] [incubator-opendal] dqhl76 opened a new pull request, #2710: ci: add fuzz test
dqhl76 opened a new pull request, #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651076009
> Maybe we should upload the `crash-b80f377b3b78e8ad25adc9a7501c973af3ca7d1d` files to artifacts if our test failed. So we can use cargo fuzz run crash-xxx to re-pro it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] oowl commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1273734090
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
+ runs-on: ubuntu-latest
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
+ - name: Test
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz run -D fuzz_range_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_writer -- -max_total_time=200
Review Comment:
There's no built-in solution for parallel action steps at the moment. Sad!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651262589
`crash_fs_fuzz_range_reader_refs/pull/2710/merge_1_05cd2fb42732366e47a32e84f7a2fca96d7b340b`
I think this crash file name has enough information and can avoid conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1274395689
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,132 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test-build-target:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
+ - name: Upload build artifacts
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target/x86_64-unknown-linux-gnu/debug/fuzz_*
+ fuzz-test-run-s3:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v2
Review Comment:
Please use actions/download-artifact@v3 instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651120968
we got the crash file [fuzz_crashes](https://github.com/apache/incubator-opendal/suites/14572666593/artifacts/825315025)
Reproduce by: `cargo fuzz run fuzz_range_reader /crash-a43d017086414fd4425807171257611ddfcc3122`
Get the Debug:fmt of input: `cargo fuzz fmt fuzz_range_reader /crash-a43d017086414fd4425807171257611ddfcc3122`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 closed pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 closed pull request #2710: ci: Add services fuzz test for read/write/range_read
URL: https://github.com/apache/incubator-opendal/pull/2710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] oowl commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1273718593
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
+ runs-on: ubuntu-latest
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
+ - name: Test
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz run -D fuzz_range_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_writer -- -max_total_time=200
Review Comment:
Splitting your task as the multiple-step task is the same behavior as your `&&` shell command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651076746
> However, I am trying to find a way to print the crash input in the log.
It's ok to save the crash file directly. Printing the crash input in the log doesn't help with our debugging: it's hard for us to implement the same test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1273705345
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
+ runs-on: ubuntu-latest
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
+ - name: Test
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz run -D fuzz_range_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_writer -- -max_total_time=200
Review Comment:
It will mix out the output and make the speed slower. Is there any method to run them concurrently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2710: ci: add s3 service fuzz test
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1650861946
Would you like to take a look again? /cc @Xuanwo @oowl
I use matrix strategy to split them into 9 jobs (`[reader, range_reader, writer] * [fs, memory, s3]`)
Advantages:
- It is easier to check the output log
Disadvantages:
- added 9 jobs, more complex
- time may still too long (9 mins)
<img width="967" alt="image" src="https://github.com/apache/incubator-opendal/assets/69136320/9ebfb541-65f0-4509-9c49-ff747c9e9595">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1274290553
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
+ runs-on: ubuntu-latest
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
+ - name: Test
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz run -D fuzz_range_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_writer -- -max_total_time=200
Review Comment:
solved by https://github.com/apache/incubator-opendal/pull/2710/commits/7e497268765c9702893234fd6870cbaea70d92eb
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
Review Comment:
solved by: https://github.com/apache/incubator-opendal/pull/2710/commits/7e497268765c9702893234fd6870cbaea70d92eb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651046080
> I think I may need to setup the environment variable to reproduce the case. Let me check out
Thanks a lot! I feel like we can remove our `fuzz_xxx` test in behaviour test in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651045093
> How can we reproduce this case?
I think I may need to setup the environment variable to reproduce the case. Let me checkout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1274659633
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,168 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test-build-target:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build
+ - name: Upload build artifacts
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target/x86_64-unknown-linux-gnu/release/fuzz_*
+ fuzz-test-run-s3:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_S3_TEST: on
+ OPENDAL_S3_BUCKET: test
+ OPENDAL_S3_ENDPOINT: "http://127.0.0.1:9000"
+ OPENDAL_S3_ACCESS_KEY_ID: minioadmin
+ OPENDAL_S3_SECRET_ACCESS_KEY: minioadmin
+ - name: Clean Github ref
+ id: ref
+ run: echo "::set-output name=ref::$(echo ${{ github.ref }} | sed 's/\//_/g')"
+ - name: Upload Crash Files
+ if: ${{ failure() }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: crash_s3_${{ matrix.fuzz-targets }}_${{ steps.ref.outputs.ref }}_${{ github.run_attempt }}_${{ github.sha }}
+ path: ./crash*
+ fuzz-test-run-fs:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_FS_TEST: on
+ OPENDAL_FS_ROOT: ${{ runner.temp }}/
+ - name: Clean Github ref
+ id: ref
+ run: echo "::set-output name=ref::$(echo ${{ github.ref }} | sed 's/\//_/g')"
+ - name: Upload Crash Files
+ uses: actions/upload-artifact@v3
+ if: ${{ failure() }}
+ with:
+ name: crash_fs_${{ matrix.fuzz-targets }}_${{ steps.ref.outputs.ref }}_${{ github.run_attempt }}_${{ github.sha }}
+ path: ./crash*
+ fuzz-test-run-memory:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_MEMORY_TEST: on
+ - name: Clean Github ref
+ id: ref
+ run: echo "::set-output name=ref::$(echo ${{ github.ref }} | sed 's/\//_/g')"
Review Comment:
Maybe we can use `${{ github.event.number }}`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1273727161
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
+ runs-on: ubuntu-latest
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
+ - name: Test
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz run -D fuzz_range_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_writer -- -max_total_time=200
Review Comment:
I may do some tests tomorrow and polish the detail. Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651068438
Maybe we should upload the `crash-b80f377b3b78e8ad25adc9a7501c973af3ca7d1d` files to artifacts if our test failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651077671
Ok. Let upload the crash file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1273847787
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
Review Comment:
Please split them in different job so that they can run concurrently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1273725440
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
+ runs-on: ubuntu-latest
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
+ - name: Test
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz run -D fuzz_range_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_writer -- -max_total_time=200
Review Comment:
Thanks for your review!
`&`: will run them at the same time.
`&&`: The next command is only executed when the previous command is executed successfully
I use `&`. I want to solve the problem that the output of the three commands is mixed together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1274575754
##########
.github/workflows/fuzz_test.yml:
##########
@@ -100,7 +100,7 @@ jobs:
if: ${{ failure() }}
uses: actions/upload-artifact@v3
with:
- name: crash_s3_${{ matrix.fuzz-targets }}_${GITHUB_REF}_${GITHUB_RUN_NUMBER}_${$EPOCHSECONDS}
+ name: crash_s3_${{ matrix.fuzz-targets }}_${{ github.ref }}_${{ github.run_attempt }}_${EPOCHSECONDS}
Review Comment:
I think crash_memory_${{ matrix.fuzz-targets }}_${{ github.ref }}_${{ github.run_attempt }}_${{ github.sha }} is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1273849385
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
+ runs-on: ubuntu-latest
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
+ - name: Test
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz run -D fuzz_range_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_writer -- -max_total_time=200
Review Comment:
Maybe we can run in different job via matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] oowl commented on a diff in pull request #2710: ci: add fuzz test
Posted by "oowl (via GitHub)" <gi...@apache.org>.
oowl commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1273681017
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
Review Comment:
Maybe we need to use a more meaningful name, like ` fuzz-test-s3`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651123224
> we got the crash file [fuzz_crashes](https://github.com/apache/incubator-opendal/suites/14572666593/artifacts/825315025)
>
> Reproduce by: `cargo fuzz run fuzz_range_reader /crash-a43d017086414fd4425807171257611ddfcc3122`
>
> Get the Debug:fmt of input: `cargo fuzz fmt fuzz_range_reader /crash-a43d017086414fd4425807171257611ddfcc3122`
Thanks a lot! We can add them in the `fuzz/README.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651042338
wow, seems we catch a case!
```shell
==1660== ERROR: libFuzzer: deadly signal
#0 0x556526ec0d11 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x2c4bd11) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#1 0x55652c048c7e (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7dd3c7e) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#2 0x55652c0272d9 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7db22d9) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#3 0x7f0c9a6e451f (/lib/x86_64-linux-gnu/libc.so.6+0x4251f) (BuildId: 69389d485a9793dbe873f0ea2c93e02efaa9aa3d)
#4 0x7f0c9a738a7b (/lib/x86_64-linux-gnu/libc.so.6+0x96a7b) (BuildId: 69389d485a9793dbe873f0ea2c93e02efaa9aa3d)
#5 0x7f0c9a6e4475 (/lib/x86_64-linux-gnu/libc.so.6+0x42475) (BuildId: 69389d485a9793dbe873f0ea2c93e02efaa9aa3d)
#6 0x7f0c9a6ca7f2 (/lib/x86_64-linux-gnu/libc.so.6+0x287f2) (BuildId: 69389d485a9793dbe873f0ea2c93e02efaa9aa3d)
#7 0x55652c139436 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7ec4436) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#8 0x556526e1ab36 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x2ba5b36) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#9 0x55652c00bc34 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7d96c34) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#10 0x55652c12d77f (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7eb877f) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#11 0x55652c12d4c0 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7eb84c0) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#12 0x55652c12a545 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7eb5545) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#13 0x55652c12d251 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7eb8251) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#14 0x556526e1e1e2 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x2ba91e2) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#15 0x556526e1e272 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x2ba9272) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#16 0x556527064af1 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x2defaf1) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#17 0x556526f[365](https://github.com/apache/incubator-opendal/actions/runs/5665172769/job/15349790214?pr=2710#step:4:366)8a (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x2cc158a) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#18 0x556527eb37f9 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x3c3e7f9) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#19 0x5565273116d8 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x309c6d8) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#20 0x556527315ccf (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x30a0ccf) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#21 0x5565271bf7db (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x2f4a7db) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#22 0x5565271c2462 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x2f4d462) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#23 0x5565271c4409 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x2f4f409) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#24 0x556527315673 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x30a0673) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#25 0x556527319154 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x30a4154) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#26 0x556527317807 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x30a2807) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#27 0x55652c006aa8 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7d91aa8) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#28 0x55652c00be47 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7d96e47) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#29 0x55652c00b0a5 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7d960a5) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#30 0x55652c027825 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7db2825) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#31 0x55652c02cc43 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7db7c43) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#32 0x55652c02dc38 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7db8c38) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#33 0x55652c030027 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7dbb027) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#34 0x55652c01ab5f (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x7da5b5f) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#35 0x556526e1eab6 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x2ba9ab6) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
#36 0x7f0c9a6cbd8f (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId: 69389d485a9793dbe873f0ea2c93e02efaa9aa3d)
#37 0x7f0c9a6cbe3f (/lib/x86_64-linux-gnu/libc.so.6+0x29e3f) (BuildId: 69389d485a9793dbe873f0ea2c93e02efaa9aa3d)
#38 0x556526e1ec54 (/home/runner/work/incubator-opendal/incubator-opendal/target/fuzz_range_reader+0x2ba9c54) (BuildId: 21214199866a4da26e035c5fce3308b35dfdd5ff)
NOTE: libFuzzer has rudimentary signal handlers.
Combine libFuzzer with AddressSanitizer or similar for better crash reports.
SUMMARY: libFuzzer: deadly signal
MS: 3 ChangeBit-CopyPart-InsertRepeatedBytes-; base unit: 260e69d75c55db9fab30c183db2e8737e88ac072
0x0,0x0,0x1,0x0,0x8,0x1,0x0,0x8,0x8,0x0,0xaf,0xaf,0xaf,0xaf,0xaf,0xaf,0xaf,0x93,0x8,0x0,0x93,
\000\000\001\000\010\001\000\010\010\000\257\257\257\257\257\257\257\223\010\000\223
artifact_prefix='./'; Test unit written to ./crash-b80f[377](https://github.com/apache/incubator-opendal/actions/runs/5665172769/job/15349790214?pr=2710#step:4:378)b3b78e8ad25adc9a7501c973af3ca7d1d
Base64: AAABAAgBAAgIAK+vr6+vr6+TCACT
```
How can we reproduce this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651075027
> I am trying to find a way to print the crash input in the log.
I'm guessing the input is not human-readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1273709980
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
+ runs-on: ubuntu-latest
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
+ - name: Test
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz run -D fuzz_range_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_writer -- -max_total_time=200
Review Comment:
Maybe we can upload these targets and download+run them in another three `job`s
Like what we do in `Docs` action https://github.com/apache/incubator-opendal/actions/runs/5658395278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1274394539
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,132 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test-build-target:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
+ - name: Upload build artifacts
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target/x86_64-unknown-linux-gnu/debug/fuzz_*
+ fuzz-test-run-s3:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v2
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Run Fuzz Test
+ shell: bash
+ run: chmod 777 ./target/${{ matrix.fuzz-targets }} && ./target/${{ matrix.fuzz-targets }} -max_total_time=120
Review Comment:
Please use `chmod +x` instead of `777`. And I prefer to split them into different steps for easy undetstanding.
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,132 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test-build-target:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
Review Comment:
I prefer to build with release profile to make sure our fuzz is the real use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1274462644
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,156 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test-build-target:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build
+ - name: Upload build artifacts
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target/x86_64-unknown-linux-gnu/release/fuzz_*
+ fuzz-test-run-s3:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_S3_TEST: on
+ OPENDAL_S3_BUCKET: test
+ OPENDAL_S3_ENDPOINT: "http://127.0.0.1:9000"
+ OPENDAL_S3_ACCESS_KEY_ID: minioadmin
+ OPENDAL_S3_SECRET_ACCESS_KEY: minioadmin
+ - name: Upload Crash Files
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_crashes
+ path: ./crash*
+ fuzz-test-run-fs:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_FS_TEST: on
+ OPENDAL_FS_ROOT: ${{ runner.temp }}/
+ - name: Upload Crash Files
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_crashes
+ path: ./crash*
+ fuzz-test-run-memory:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_MEMORY_TEST: on
+ - name: Upload Crash Files
Review Comment:
You are so familiar with that. Compile by brain 🤯
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,156 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test-build-target:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build
+ - name: Upload build artifacts
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target/x86_64-unknown-linux-gnu/release/fuzz_*
+ fuzz-test-run-s3:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_S3_TEST: on
+ OPENDAL_S3_BUCKET: test
+ OPENDAL_S3_ENDPOINT: "http://127.0.0.1:9000"
+ OPENDAL_S3_ACCESS_KEY_ID: minioadmin
+ OPENDAL_S3_SECRET_ACCESS_KEY: minioadmin
+ - name: Upload Crash Files
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_crashes
+ path: ./crash*
+ fuzz-test-run-fs:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_FS_TEST: on
+ OPENDAL_FS_ROOT: ${{ runner.temp }}/
+ - name: Upload Crash Files
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_crashes
+ path: ./crash*
+ fuzz-test-run-memory:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_MEMORY_TEST: on
+ - name: Upload Crash Files
Review Comment:
You are so familiar with that. Compile by brain 🤯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1274571827
##########
.github/workflows/fuzz_test.yml:
##########
@@ -100,7 +100,7 @@ jobs:
if: ${{ failure() }}
uses: actions/upload-artifact@v3
with:
- name: crash_s3_${{ matrix.fuzz-targets }}_${GITHUB_REF}_${GITHUB_RUN_NUMBER}_${$EPOCHSECONDS}
+ name: crash_s3_${{ matrix.fuzz-targets }}_${{ github.ref }}_${{ github.run_attempt }}_${EPOCHSECONDS}
Review Comment:
Where is `EPOCHSECONDS` from? We can remove this if we already have `github.run_attempt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651074054
> Maybe we should upload the `crash-b80f377b3b78e8ad25adc9a7501c973af3ca7d1d` files to artifacts if our test failed.
Yes. I reproduce it by using the crash file successfully. However, I am trying to find a way to print the crash input in the log. When I use `cargo fuzz run ..` it will print, but if it run by a build artifact seems not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651449090
Wait for https://github.com/apache/incubator-opendal/pull/2718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1274484583
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,159 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test-build-target:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build
+ - name: Upload build artifacts
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target/x86_64-unknown-linux-gnu/release/fuzz_*
+ fuzz-test-run-s3:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_S3_TEST: on
+ OPENDAL_S3_BUCKET: test
+ OPENDAL_S3_ENDPOINT: "http://127.0.0.1:9000"
+ OPENDAL_S3_ACCESS_KEY_ID: minioadmin
+ OPENDAL_S3_SECRET_ACCESS_KEY: minioadmin
+ - name: Upload Crash Files
+ if: ${{ failure() }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_crashes
Review Comment:
we could have different fuzz crashes, it's better to contain the following things:
- pr number
- services name
- fuzz targert
And a timestamp to avoid conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1273685239
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
Review Comment:
It also test memory and fs.
https://github.com/apache/incubator-opendal/blob/bfe96212dca0035ee8bde90adbf7305cfb34054e/.github/workflows/fuzz_test.yml#L75-L77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#issuecomment-1651014284
All comment solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1274458865
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,156 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test-build-target:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build
+ - name: Upload build artifacts
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target/x86_64-unknown-linux-gnu/release/fuzz_*
+ fuzz-test-run-s3:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_S3_TEST: on
+ OPENDAL_S3_BUCKET: test
+ OPENDAL_S3_ENDPOINT: "http://127.0.0.1:9000"
+ OPENDAL_S3_ACCESS_KEY_ID: minioadmin
+ OPENDAL_S3_SECRET_ACCESS_KEY: minioadmin
+ - name: Upload Crash Files
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_crashes
+ path: ./crash*
+ fuzz-test-run-fs:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_FS_TEST: on
+ OPENDAL_FS_ROOT: ${{ runner.temp }}/
+ - name: Upload Crash Files
+ uses: actions/upload-artifact@v3
+ with:
+ name: fuzz_crashes
+ path: ./crash*
+ fuzz-test-run-memory:
+ runs-on: ubuntu-latest
+ needs: fuzz-test-build-target
+ strategy:
+ fail-fast: true
+ matrix:
+ fuzz-targets: [ fuzz_reader, fuzz_range_reader, fuzz_writer ]
+ steps:
+ - name: Download Fuzz Targets
+ uses: actions/download-artifact@v3
+ with:
+ name: fuzz_targets
+ path: ./target
+ - name: Grant Execute Permissions
+ shell: bash
+ run: chmod +x ./target/${{ matrix.fuzz-targets }}
+ - name: Run Fuzz Test
+ shell: bash
+ run: ./target/${{ matrix.fuzz-targets }} -max_total_time=120
+ env:
+ OPENDAL_MEMORY_TEST: on
+ - name: Upload Crash Files
Review Comment:
Failed test will skip this step, we need to add a if failure here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2710: ci: add s3 service fuzz test
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1273709980
##########
.github/workflows/fuzz_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+name: Fuzz Test
+
+on:
+ push:
+ branches:
+ - main
+ - fuzz-ci
+ pull_request:
+ branches:
+ - main
+ paths:
+ - "core/src/**"
+ - "!core/src/docs/**"
+ - "!core/src/services/**"
+ - "core/src/services/fs/**"
+ - "core/src/services/memory/**"
+ - "core/src/services/s3/**"
+ - ".github/workflows/fuzz_test.yml"
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ cancel-in-progress: true
+
+jobs:
+ fuzz-test:
+ runs-on: ubuntu-latest
+ services:
+ minio:
+ image: wktk/minio-server
+ ports:
+ - 9000:9000
+ env:
+ MINIO_ACCESS_KEY: "minioadmin"
+ MINIO_SECRET_KEY: "minioadmin"
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Test Bucket
+ env:
+ AWS_ACCESS_KEY_ID: "minioadmin"
+ AWS_SECRET_ACCESS_KEY: "minioadmin"
+ AWS_EC2_METADATA_DISABLED: "true"
+ run: aws --endpoint-url http://127.0.0.1:9000/ s3 mb s3://test
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup
+ - name: Install cargo fuzz
+ shell: bash
+ run: rustup install nightly && cargo +nightly install cargo-fuzz
+ - name: Build Fuzz Targets
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz build -D
+ - name: Test
+ shell: bash
+ working-directory: core/fuzz
+ run: cargo +nightly fuzz run -D fuzz_range_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_reader -- -max_total_time=200 & cargo +nightly fuzz run -D fuzz_writer -- -max_total_time=200
Review Comment:
Maybe we can upload these targets and download+run them in another three `job`s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2710: ci: Add services fuzz test for read/write/range_read
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2710:
URL: https://github.com/apache/incubator-opendal/pull/2710#discussion_r1274573367
##########
.github/workflows/fuzz_test.yml:
##########
@@ -100,7 +100,7 @@ jobs:
if: ${{ failure() }}
uses: actions/upload-artifact@v3
with:
- name: crash_s3_${{ matrix.fuzz-targets }}_${GITHUB_REF}_${GITHUB_RUN_NUMBER}_${$EPOCHSECONDS}
+ name: crash_s3_${{ matrix.fuzz-targets }}_${{ github.ref }}_${{ github.run_attempt }}_${EPOCHSECONDS}
Review Comment:
EPOCHSECONDS is a linux environment variable. I may need a `echo` to join the string. I think `github.run_attempt` is enought
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org