You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fx-dev@ws.apache.org by "Thomas Leonard (JIRA)" <ji...@apache.org> on 2005/09/29 10:49:48 UTC
[jira] Created: (WSS-20) Better error reporting from CryptoFactory.loadClass() [patch]
Better error reporting from CryptoFactory.loadClass() [patch]
-------------------------------------------------------------
Key: WSS-20
URL: http://issues.apache.org/jira/browse/WSS-20
Project: WSS4J
Type: Improvement
Reporter: Thomas Leonard
Assigned to: Davanum Srinivas
loadClass() first tries to construct an instance of cryptogenClass with a single properties parameter to the constructor. If this fails, it tries again with no arguments. If this second attempt fails, it reports a generic message saying "cannot create instance". This is not very helpful, as it does not pass on any error reported by the code.
Perhaps it would be better to check which constructor exists, use that, and report any error back to the user? I have a patch to do this, which I will attach.
Note: This causes a change in behaviour if the class has *both* constructors, since it will only try the one which takes the parameter. However, I think this is more likely to be the correct behaviour.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org
[jira] Closed: (WSS-20) Better error reporting from
CryptoFactory.loadClass() [patch]
Posted by "Werner Dittmann (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WSS-20?page=all ]
Werner Dittmann closed WSS-20:
------------------------------
Resolution: Fixed
Related/similar to WSS-30 and WSS-31, both are fixed.
> Better error reporting from CryptoFactory.loadClass() [patch]
> -------------------------------------------------------------
>
> Key: WSS-20
> URL: http://issues.apache.org/jira/browse/WSS-20
> Project: WSS4J
> Type: Improvement
> Reporter: Thomas Leonard
> Assignee: Davanum Srinivas
> Attachments: CryptoFactory.patch
>
> loadClass() first tries to construct an instance of cryptogenClass with a single properties parameter to the constructor. If this fails, it tries again with no arguments. If this second attempt fails, it reports a generic message saying "cannot create instance". This is not very helpful, as it does not pass on any error reported by the code.
> Perhaps it would be better to check which constructor exists, use that, and report any error back to the user? I have a patch to do this, which I will attach.
> Note: This causes a change in behaviour if the class has *both* constructors, since it will only try the one which takes the parameter. However, I think this is more likely to be the correct behaviour.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org
[jira] Updated: (WSS-20) Better error reporting from CryptoFactory.loadClass() [patch]
Posted by "Thomas Leonard (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WSS-20?page=all ]
Thomas Leonard updated WSS-20:
------------------------------
Attachment: CryptoFactory.patch
> Better error reporting from CryptoFactory.loadClass() [patch]
> -------------------------------------------------------------
>
> Key: WSS-20
> URL: http://issues.apache.org/jira/browse/WSS-20
> Project: WSS4J
> Type: Improvement
> Reporter: Thomas Leonard
> Assignee: Davanum Srinivas
> Attachments: CryptoFactory.patch
>
> loadClass() first tries to construct an instance of cryptogenClass with a single properties parameter to the constructor. If this fails, it tries again with no arguments. If this second attempt fails, it reports a generic message saying "cannot create instance". This is not very helpful, as it does not pass on any error reported by the code.
> Perhaps it would be better to check which constructor exists, use that, and report any error back to the user? I have a patch to do this, which I will attach.
> Note: This causes a change in behaviour if the class has *both* constructors, since it will only try the one which takes the parameter. However, I think this is more likely to be the correct behaviour.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org
[jira] Closed: (WSS-20) Better error reporting from
CryptoFactory.loadClass() [patch]
Posted by "Werner Dittmann (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WSS-20?page=all ]
Werner Dittmann closed WSS-20:
------------------------------
Resolution: Fixed
Related/similar to WSS-30 and WSS-31, both are fixed.
> Better error reporting from CryptoFactory.loadClass() [patch]
> -------------------------------------------------------------
>
> Key: WSS-20
> URL: http://issues.apache.org/jira/browse/WSS-20
> Project: WSS4J
> Type: Improvement
> Reporter: Thomas Leonard
> Assignee: Davanum Srinivas
> Attachments: CryptoFactory.patch
>
> loadClass() first tries to construct an instance of cryptogenClass with a single properties parameter to the constructor. If this fails, it tries again with no arguments. If this second attempt fails, it reports a generic message saying "cannot create instance". This is not very helpful, as it does not pass on any error reported by the code.
> Perhaps it would be better to check which constructor exists, use that, and report any error back to the user? I have a patch to do this, which I will attach.
> Note: This causes a change in behaviour if the class has *both* constructors, since it will only try the one which takes the parameter. However, I think this is more likely to be the correct behaviour.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org
[jira] Updated: (WSS-20) Better error reporting from CryptoFactory.loadClass() [patch]
Posted by "Thomas Leonard (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/WSS-20?page=all ]
Thomas Leonard updated WSS-20:
------------------------------
Attachment: CryptoFactory.patch
> Better error reporting from CryptoFactory.loadClass() [patch]
> -------------------------------------------------------------
>
> Key: WSS-20
> URL: http://issues.apache.org/jira/browse/WSS-20
> Project: WSS4J
> Type: Improvement
> Reporter: Thomas Leonard
> Assignee: Davanum Srinivas
> Attachments: CryptoFactory.patch
>
> loadClass() first tries to construct an instance of cryptogenClass with a single properties parameter to the constructor. If this fails, it tries again with no arguments. If this second attempt fails, it reports a generic message saying "cannot create instance". This is not very helpful, as it does not pass on any error reported by the code.
> Perhaps it would be better to check which constructor exists, use that, and report any error back to the user? I have a patch to do this, which I will attach.
> Note: This causes a change in behaviour if the class has *both* constructors, since it will only try the one which takes the parameter. However, I think this is more likely to be the correct behaviour.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: wss4j-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: wss4j-dev-help@ws.apache.org