[GitHub] adriancole commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector

[GitBox <gi...@apache.org>]

adriancole commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector
URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-395458531
 
 
   @wu-sheng so the remoteEndpoint is optional in zipkin's schema, representing usually network layer detail of the upstream or downstream (ex x-forwarded-for for incoming servlet request).
   
   We do not propagate data about the upstream to know authoritatively its name. So, usually a server span will be missing remoteEndpoint.serviceName. If it was known, then the valid value would be set.
   
   Note: that there's nothing technically impossible about propagating upstream via headers (such as census tags do), just it isn't defined. So similar to zipkin-gcp and zipkin-aws we could have a brave or other language helper that changes propagation to include the extra root-level data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services