You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Amogh Vasekar <am...@citrix.com> on 2014/05/07 00:50:23 UTC
Review Request 21131: Remove hard coding of guest OS mapping for KVM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21131/
-----------------------------------------------------------
Review request for cloudstack and Nitin Mehta.
Bugs: https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
Repository: cloudstack-git
Description
-------
As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
This patch is for KVM
This patch is to be applied after https://reviews.apache.org/r/21087/
Diffs
-----
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java 3b05120f5b9d5bcf4bab6ef25cd1dab2a6043c0d
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 345a8eea0cf3033eef10accdd94639bf014b0fb3
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 4032305b03268b4b8b93a3f41038dce83bcaaf19
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/VifDriverBase.java d89d71a1b2a93959ebcd4f0df529901e12445617
Diff: https://reviews.apache.org/r/21131/diff/
Testing
-------
1. Local testing on KVM
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Snapshots are not supported for KVM
Thanks,
Amogh Vasekar
Re: Review Request 21131: Remove hard coding of guest OS mapping for KVM
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21131/#review42433
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On May 7, 2014, 12:26 a.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21131/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 12:26 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
> This patch is for KVM
> This patch is to be applied after https://reviews.apache.org/r/21087/
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java 3b05120f5b9d5bcf4bab6ef25cd1dab2a6043c0d
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 345a8eea0cf3033eef10accdd94639bf014b0fb3
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 4032305b03268b4b8b93a3f41038dce83bcaaf19
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/VifDriverBase.java d89d71a1b2a93959ebcd4f0df529901e12445617
> server/src/com/cloud/hypervisor/KVMGuru.java 174b32db578f66da83ed86e942f7f5b316512a55
>
> Diff: https://reviews.apache.org/r/21131/diff/
>
>
> Testing
> -------
>
> 1. Local testing on KVM
> 2. Successfully got up system VMs
> 3. Successfully created a CentOS VM
> 4. Snapshots are not supported for KVM
>
>
> Thanks,
>
> Amogh Vasekar
>
>
Re: Review Request 21131: Remove hard coding of guest OS mapping for KVM
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21131/
-----------------------------------------------------------
(Updated May 7, 2014, 12:26 a.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Cleaning up code
Bugs: https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
Repository: cloudstack-git
Description
-------
As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
This patch is for KVM
This patch is to be applied after https://reviews.apache.org/r/21087/
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java 3b05120f5b9d5bcf4bab6ef25cd1dab2a6043c0d
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 345a8eea0cf3033eef10accdd94639bf014b0fb3
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 4032305b03268b4b8b93a3f41038dce83bcaaf19
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/VifDriverBase.java d89d71a1b2a93959ebcd4f0df529901e12445617
server/src/com/cloud/hypervisor/KVMGuru.java 174b32db578f66da83ed86e942f7f5b316512a55
Diff: https://reviews.apache.org/r/21131/diff/
Testing
-------
1. Local testing on KVM
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Snapshots are not supported for KVM
Thanks,
Amogh Vasekar
Re: Review Request 21131: Remove hard coding of guest OS mapping for KVM
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21131/
-----------------------------------------------------------
(Updated May 7, 2014, 12:11 a.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Add missing file
Bugs: https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
Repository: cloudstack-git
Description
-------
As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
This patch is for KVM
This patch is to be applied after https://reviews.apache.org/r/21087/
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java 3b05120f5b9d5bcf4bab6ef25cd1dab2a6043c0d
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 345a8eea0cf3033eef10accdd94639bf014b0fb3
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 4032305b03268b4b8b93a3f41038dce83bcaaf19
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/VifDriverBase.java d89d71a1b2a93959ebcd4f0df529901e12445617
server/src/com/cloud/hypervisor/KVMGuru.java 174b32db578f66da83ed86e942f7f5b316512a55
Diff: https://reviews.apache.org/r/21131/diff/
Testing
-------
1. Local testing on KVM
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Snapshots are not supported for KVM
Thanks,
Amogh Vasekar
Re: Review Request 21131: Remove hard coding of guest OS mapping for KVM
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21131/
-----------------------------------------------------------
(Updated May 6, 2014, 10:51 p.m.)
Review request for cloudstack and Nitin Mehta.
Bugs: https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
Repository: cloudstack-git
Description
-------
As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
This patch is for KVM
This patch is to be applied after https://reviews.apache.org/r/21087/
Diffs
-----
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java 3b05120f5b9d5bcf4bab6ef25cd1dab2a6043c0d
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 345a8eea0cf3033eef10accdd94639bf014b0fb3
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 4032305b03268b4b8b93a3f41038dce83bcaaf19
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/VifDriverBase.java d89d71a1b2a93959ebcd4f0df529901e12445617
Diff: https://reviews.apache.org/r/21131/diff/
Testing
-------
1. Local testing on KVM
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Snapshots are not supported for KVM
Thanks,
Amogh Vasekar