You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by "irajhedayati (via GitHub)" <gi...@apache.org> on 2023/03/06 00:01:54 UTC
[GitHub] [bahir] irajhedayati opened a new pull request, #107: Bump google-api-services-pubsub to 2.0.0
irajhedayati opened a new pull request, #107:
URL: https://github.com/apache/bahir/pull/107
The Google API clients are now at major version 2, which, if used in the same project, will cause compatibility issues.
For example, `org.apache.bahir:spark-streaming-pubsub_2.12:2.4.0` uses `com.google.apis:google-api-services-pubsub:v1-rev355-1.22.0` while Spark GCS connector **2.2.11** is using **2.2.0**. Then in runtime, we get
```
Caused by: java.lang.IllegalStateException: You are currently running with version 2.2.0 of google-api-client. You need at least version 1.15 of google-api-client to run version 1.22.0 of the Google Cloud Pub/Sub API library.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir] mhdkassir commented on a diff in pull request #107: Bump google-api-services-pubsub to 2.0.0
Posted by "mhdkassir (via GitHub)" <gi...@apache.org>.
mhdkassir commented on code in PR #107:
URL: https://github.com/apache/bahir/pull/107#discussion_r1239467547
##########
streaming-pubsub/pom.xml:
##########
Review Comment:
Hello , @irajhedayati I am interested by this PR , does it work for you ? The version of the jar you reference (<version>v1-rev20230124-2.0.0</version>) doesn't seem to be available on maven repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir] irajhedayati commented on a diff in pull request #107: Bump google-api-services-pubsub to 2.0.0
Posted by "irajhedayati (via GitHub)" <gi...@apache.org>.
irajhedayati commented on code in PR #107:
URL: https://github.com/apache/bahir/pull/107#discussion_r1241016323
##########
streaming-pubsub/pom.xml:
##########
Review Comment:
Hi @mhdkassir, yes, it works for me. Here is the link to this version
https://mvnrepository.com/artifact/com.google.apis/google-api-services-pubsub/v1-rev20230124-2.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir] mhdkassir commented on a diff in pull request #107: Bump google-api-services-pubsub to 2.0.0
Posted by "mhdkassir (via GitHub)" <gi...@apache.org>.
mhdkassir commented on code in PR #107:
URL: https://github.com/apache/bahir/pull/107#discussion_r1241067071
##########
streaming-pubsub/pom.xml:
##########
Review Comment:
@irajhedayati thank you, I found it and it works for me too. For some reason the when searching using the mvn repo UI new versions don't appear in the results although they are available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bahir] irajhedayati commented on pull request #107: Bump google-api-services-pubsub to 2.0.0
Posted by "irajhedayati (via GitHub)" <gi...@apache.org>.
irajhedayati commented on PR #107:
URL: https://github.com/apache/bahir/pull/107#issuecomment-1724731616
@mhdkassir do you think it's good to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@bahir.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org