[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #7034: Decimal256 coercion

["Dandandan (via GitHub)" <gi...@apache.org>]

Dandandan commented on code in PR #7034:
URL: https://github.com/apache/arrow-datafusion/pull/7034#discussion_r1269899302


##########
datafusion/expr/src/type_coercion/aggregates.rs:
##########
@@ -480,7 +480,7 @@ pub fn is_avg_support_arg_type(arg_type: &DataType) -> bool {
         _ => matches!(
             arg_type,
             arg_type if NUMERICS.contains(arg_type)
-                || matches!(arg_type, DataType::Decimal128(_, _))
+                || matches!(arg_type, DataType::Decimal128(_, _)| DataType::Decimal256(_, _))

Review Comment:
   `simplify_expressions` is an optimization pass on the logical plan.
   I suppose you're not using those or having your own.
   
   Anyway, would be good to have some more support / (end-to-end) tests for `Decimal256`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org