You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/12/31 10:52:02 UTC
Review Request 29509: CLOUDSATCK-8138: Fixed VmSnapshot revert issue
in test_escalations_instances.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29509/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8138
https://issues.apache.org/jira/browse/CLOUDSTACK-8138
Repository: cloudstack-git
Description
-------
The VM should be in running state while reverting the snapshot because the VmSnapshot includes memorySnapshot too.
Diffs
-----
test/integration/component/test_escalations_instances.py 1e5ec5331b9e95d9e7cae5cd5071e0789525c67e
Diff: https://reviews.apache.org/r/29509/diff/
Testing
-------
Yes.
Thanks,
Gaurav Aradhye
Re: Review Request 29509: CLOUDSATCK-8138: Fixed VmSnapshot revert
issue in test_escalations_instances.py
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On Jan. 5, 2015, 6:50 p.m., SrikanteswaraRao Talluri wrote:
> > 22d6565434e31a8c65953a9eb1b8bfeea1c0f1d0 master
>
> SrikanteswaraRao Talluri wrote:
> doesn't apply on 4.5
4.5 branch does not need this patch, closing the review request.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29509/#review66632
-----------------------------------------------------------
On Dec. 31, 2014, 3:22 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29509/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2014, 3:22 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8138
> https://issues.apache.org/jira/browse/CLOUDSTACK-8138
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The VM should be in running state while reverting the snapshot because the VmSnapshot includes memorySnapshot too.
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py 1e5ec5331b9e95d9e7cae5cd5071e0789525c67e
>
> Diff: https://reviews.apache.org/r/29509/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 29509: CLOUDSATCK-8138: Fixed VmSnapshot revert
issue in test_escalations_instances.py
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
> On Jan. 5, 2015, 1:20 p.m., SrikanteswaraRao Talluri wrote:
> > 22d6565434e31a8c65953a9eb1b8bfeea1c0f1d0 master
doesn't apply on 4.5
- SrikanteswaraRao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29509/#review66632
-----------------------------------------------------------
On Dec. 31, 2014, 9:52 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29509/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2014, 9:52 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8138
> https://issues.apache.org/jira/browse/CLOUDSTACK-8138
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The VM should be in running state while reverting the snapshot because the VmSnapshot includes memorySnapshot too.
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py 1e5ec5331b9e95d9e7cae5cd5071e0789525c67e
>
> Diff: https://reviews.apache.org/r/29509/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 29509: CLOUDSATCK-8138: Fixed VmSnapshot revert
issue in test_escalations_instances.py
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29509/#review66632
-----------------------------------------------------------
Ship it!
22d6565434e31a8c65953a9eb1b8bfeea1c0f1d0 master
- SrikanteswaraRao Talluri
On Dec. 31, 2014, 9:52 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29509/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2014, 9:52 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8138
> https://issues.apache.org/jira/browse/CLOUDSTACK-8138
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The VM should be in running state while reverting the snapshot because the VmSnapshot includes memorySnapshot too.
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py 1e5ec5331b9e95d9e7cae5cd5071e0789525c67e
>
> Diff: https://reviews.apache.org/r/29509/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>