You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Colin McCabe (Jira)" <ji...@apache.org> on 2020/09/26 22:41:00 UTC
[jira] [Commented] (KAFKA-10496) Create an in-memory DNS server for
ClientUtilsTest and ClusterConnectionStatesTest
[ https://issues.apache.org/jira/browse/KAFKA-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202698#comment-17202698 ]
Colin McCabe commented on KAFKA-10496:
--------------------------------------
Thanks for filing this, [~jolshan]. I noticed this test started failing as well. It's really bad for our unit tests to have a dependency on a website that can change-- even if it is our website... :\
> Create an in-memory DNS server for ClientUtilsTest and ClusterConnectionStatesTest
> ----------------------------------------------------------------------------------
>
> Key: KAFKA-10496
> URL: https://issues.apache.org/jira/browse/KAFKA-10496
> Project: Kafka
> Issue Type: Improvement
> Reporter: Justine Olshan
> Assignee: Piotr Rżysko
> Priority: Minor
>
> ClientUtilsTest and ClusterConnectionStatesTest currently use an external DNS to resolve the IP addresses for kafka.apache.org. Until recently there were only two IP4 addresses, but now there is a third.
> At first the tests were changed to just check for multiple addresses. [https://github.com/apache/kafka/pull/9294]
> However, these tests are pretty fragile when they rely on outside sources, so it would make sense to create an in-memory DNS. This is what netty does for similar tests.
> [https://github.com/netty/netty/blob/master/resolver-dns/src/test/java/io/netty/resolver/dns/TestDnsServer.java].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)