You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/22 03:04:13 UTC
[GitHub] [superset] diegomedina248 opened a new pull request, #20816: fix: chart empty state & result panel when multiple queries are executed display incorrectly
diegomedina248 opened a new pull request, #20816:
URL: https://github.com/apache/superset/pull/20816
### SUMMARY
Depending on the number of queries being executed for a given chart, we are displaying the results in panels at the bottom (explore).
This causes some issues, because the "Show Totals" and pagination features add extra queries, leading, for instance, a table to display more than one result panel, which is incorrect.
The same issue appears for the chart empty state, since having multiple queries can make the state not to appear, as expected.
We currently have a `getQueryCount` util that is used in some (but not all) places. This PR moves that value to the chart metadata and then queries it in all the necessary places to solve the issue mentioned above.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://user-images.githubusercontent.com/17252075/180353269-f5d599ec-d7dd-4a2e-9a3a-d792847916fc.mov
After:
https://user-images.githubusercontent.com/17252075/180353372-60e2ff11-fcd1-4fa7-8c6e-2103d6aa4faa.mov
### TESTING INSTRUCTIONS
1. Create a chart table
2. Enable Show Totals
3. Update the chart
Ensure the results panel show only a single result.
Repeat the process above, but for a Mixed Timeseries chart. Ensure you can see two results panels.
For the chart above, add some filters that would yield no results.
Update the chart and ensure you can see the empty state.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #20816: fix: chart empty state & result panel when multiple queries are executed display incorrectly
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged PR #20816:
URL: https://github.com/apache/superset/pull/20816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20816: fix: chart empty state & result panel when multiple queries are executed display incorrectly
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20816:
URL: https://github.com/apache/superset/pull/20816#issuecomment-1192150808
# [Codecov](https://codecov.io/gh/apache/superset/pull/20816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20816](https://codecov.io/gh/apache/superset/pull/20816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fe22e4) into [master](https://codecov.io/gh/apache/superset/commit/af1bddffad930efc0583b638716980db6747bfbc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af1bddf) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 7fe22e4 differs from pull request most recent head 18443b3. Consider uploading reports for the commit 18443b3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #20816 +/- ##
=======================================
Coverage 66.30% 66.30%
=======================================
Files 1758 1757 -1
Lines 66802 66804 +2
Branches 7056 7058 +2
=======================================
+ Hits 44294 44296 +2
Misses 20710 20710
Partials 1798 1798
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.98% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../plugin-chart-echarts/src/MixedTimeseries/index.ts](https://codecov.io/gh/apache/superset/pull/20816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvTWl4ZWRUaW1lc2VyaWVzL2luZGV4LnRz) | `25.00% <ø> (ø)` | |
| [...perset-ui-core/src/chart/components/SuperChart.tsx](https://codecov.io/gh/apache/superset/pull/20816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY2hhcnQvY29tcG9uZW50cy9TdXBlckNoYXJ0LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...superset-ui-core/src/chart/models/ChartMetadata.ts](https://codecov.io/gh/apache/superset/pull/20816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY2hhcnQvbW9kZWxzL0NoYXJ0TWV0YWRhdGEudHM=) | `100.00% <100.00%> (ø)` | |
| [...nents/DataTablesPane/components/useResultsPane.tsx](https://codecov.io/gh/apache/superset/pull/20816/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9jb21wb25lbnRzL3VzZVJlc3VsdHNQYW5lLnRzeA==) | `97.50% <100.00%> (+0.06%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org