[GitHub] [geode] pdxrunner opened pull request #2488: GEODE-5741: Apply fixes from StartLocator test to StartServer test

["pdxrunner (GitHub)" <gi...@apache.org>]

* make tests use relative paths
* remove system dependent path separators

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2488 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #2488: GEODE-5741: Apply fixes from StartLocator test to StartServer test

["kirklund (GitHub)" <gi...@apache.org>]

For these permissions tests, you could potentially abstract all file manipulation away from the class(es) under test, add a constructor that let's you pass in YourFileManipulationClass and then have the test create a YourFileManipulationClass that throws permissions exceptions.

We don't really need to test with the file system throwing exceptions at our code. We just want to verify the behavior of "start server" when it's unable to create a directory. Maybe a mocking based test would be better.

[ Full content available at: https://github.com/apache/geode/pull/2488 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner commented on issue #2488: GEODE-5741: Apply fixes from StartLocator test to StartServer test

["pdxrunner (GitHub)" <gi...@apache.org>]

Closing to rebase against current develop.

[ Full content available at: https://github.com/apache/geode/pull/2488 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner commented on pull request #2488: GEODE-5741: Apply fixes from StartLocator test to StartServer test

["pdxrunner (GitHub)" <gi...@apache.org>]

Not sure if this is what you were thinking, but I've moved those dir creation failure tests into StartMemberUtilsTest where the result of `File.mkdirs()` can be mocked to simulate the failure.

[ Full content available at: https://github.com/apache/geode/pull/2488 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner closed pull request #2488: GEODE-5741: Apply fixes from StartLocator test to StartServer test

["pdxrunner (GitHub)" <gi...@apache.org>]

[ pull request closed by pdxrunner ]

[ Full content available at: https://github.com/apache/geode/pull/2488 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org