[jira] [Commented] (KNOX-1532) Only decompress/recompress when there are rewrite rules

["Kevin Risden (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657007#comment-16657007 ] 

Kevin Risden commented on KNOX-1532:
------------------------------------

What doesn't make sense to me is:

UrlRewriteStreamFilterFactory.create() returns an InputStream. The name of the factory is UrlRewriteStreamFilterFactory it should return a UrlRewriteStreamFilter and not run the filter. 

Without changing the signature there is no way to short circuit gzip decompression. I think changing the signature to return UrlRewriteStreamFilter is actually better and that frees the caller to call filter (without sending in so many arguments to create()).

> Only decompress/recompress when there are rewrite rules
> -------------------------------------------------------
>
>                 Key: KNOX-1532
>                 URL: https://issues.apache.org/jira/browse/KNOX-1532
>             Project: Apache Knox
>          Issue Type: Sub-task
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Major
>             Fix For: 1.2.0
>
>
> See parent ticket KNOX-1530 for details.
>  
> This won't take affect until KNOX-1533 is also complete.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)