You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/03/16 12:56:11 UTC
[GitHub] [ignite] ptupitsyn commented on a change in pull request #8883: IGNITE-14320 .NET: Fix invocation .Net -> .Net services with system types arguments
ptupitsyn commented on a change in pull request #8883:
URL: https://github.com/apache/ignite/pull/8883#discussion_r595136996
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/TypeNameParser.cs
##########
@@ -172,7 +172,7 @@ public bool HasNamespace()
/// </summary>
public string GetNamespace()
{
- return NameStart == 0 ? null : _typeName.Substring(_start, NameStart);
+ return NameStart == 0 ? null : _typeName.Substring(_start, NameStart - _start);
Review comment:
Please add a test to `TypeNameParserTest` to cover this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org