[GitHub] [hbase] wchevreuil commented on a diff in pull request #4945: HBASE-27551 Add config options to delay assignment to retain last region location

[GitBox <gi...@apache.org>]

wchevreuil commented on code in PR #4945:
URL: https://github.com/apache/hbase/pull/4945#discussion_r1063330602


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java:
##########
@@ -188,6 +222,27 @@ protected boolean waitInitialized(MasterProcedureEnv env) {
     return am.waitMetaLoaded(this) || am.waitMetaAssigned(this, getRegion());
   }
 
+  private void checkAndWaitForOriginalServer(ServerName lastHost)
+    throws ProcedureSuspendedException {
+    boolean isOnline = serverManager.findServerWithSameHostnamePortWithLock(lastHost) != null;
+    long retries = 0;
+    while (!isOnline && retries < forceRegionRetainmentRetries) {
+      try {
+        synchronized (this) {

Review Comment:
   Not really, this would only be called by each TRSP individually. Removing this synchronized block on next commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org