[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6143: Use PostgreSQL 9.6-compatible syntax in create_tables.sql and migrations

[GitBox <gi...@apache.org>]

zrhoffman commented on a change in pull request #6143:
URL: https://github.com/apache/trafficcontrol/pull/6143#discussion_r696986729



##########
File path: traffic_ops/app/db/migrations/2021061100000000_ds_tls_versions.up.sql
##########
@@ -39,20 +39,18 @@ BEGIN
 	SET last_updated=now()
 	WHERE id IN (
 		SELECT deliveryservice
-		FROM old_table
+		FROM deliveryservice_tls_version
 	);
 	RETURN NULL;
 END;
 $$ LANGUAGE plpgsql;
 
 CREATE TRIGGER update_ds_timestamp_on_tls_version_insertion
 	AFTER INSERT ON public.deliveryservice_tls_version
-	REFERENCING NEW TABLE AS new_table
 	FOR EACH STATEMENT EXECUTE PROCEDURE update_ds_timestamp_on_insert();
 
 CREATE TRIGGER update_ds_timestamp_on_tls_version_delete
 	AFTER DELETE ON public.deliveryservice_tls_version
-	REFERENCING OLD TABLE AS old_table

Review comment:
       Right you are. Changed to `OLD` and `NEW` in the trigger functions in 7e3ced29a0.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org