You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/06 00:18:39 UTC

[GitHub] Licht-T commented on a change in pull request #1182: Remove constexpr from C++ client

Licht-T commented on a change in pull request #1182: Remove constexpr from C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1182#discussion_r166154044
 
 

 ##########
 File path: pulsar-client-cpp/lib/Murmur3_32Hash.h
 ##########
 @@ -38,9 +38,6 @@ class Murmur3_32Hash : public Hash {
     int32_t makeHash(const std::string& key);
 
    private:
-    static constexpr int32_t CHUNK_SIZE = 4;
 
 Review comment:
   @merlimat Yes! But the value definition will be in `cc` file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services