You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/09/08 01:24:56 UTC

[GitHub] [arrow] kou commented on a diff in pull request #37612: GH-36379: [C++] Bundled dependency include paths should override system include dirs

kou commented on code in PR #37612:
URL: https://github.com/apache/arrow/pull/37612#discussion_r1319252133


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2600,6 +2602,7 @@ endmacro()
 if(ARROW_WITH_BZ2)
   resolve_dependency(BZip2 PC_PACKAGE_NAMES bzip2)
 
+  # XXX if resolve_dependency is called, won't we have either BZip2::BZip2 or an error?
   if(NOT TARGET BZip2::BZip2)
     add_library(BZip2::BZip2 UNKNOWN IMPORTED)
     set_target_properties(BZip2::BZip2

Review Comment:
   This block is for CMake < 3.12. So we can remove this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org