You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/21 11:23:51 UTC

[GitHub] KellenSunderland opened a new pull request #12270: [MXNET-848] Pin dockcross base images to known working versions

KellenSunderland opened a new pull request #12270: [MXNET-848] Pin dockcross base images to known working versions
URL: https://github.com/apache/incubator-mxnet/pull/12270
 
 
   ## Description ##
   This PR will pin our dockcross base images to known working versions.  Pinning these images is necessary as we've had cases where following the 'latest' tag in dockerhub leads us to picking up broken, or incompatible images.  Though the dockcross images are generally high-quality we'd like to avoid these issues from blocking our CI in the future.
   
   The disadvantage here is that we will lose visibility in valid failures for things like new cmake versions that potentially break on ARM builds.  We feel that these test should be done independently of PR validation, and would be best suited for the nightly test runs.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services