[GitHub] [hadoop] omalley commented on a diff in pull request #4527: HADOOP-18324. Interrupting RPC Client calls can lead to thread exhaustion.

[GitBox <gi...@apache.org>]

omalley commented on code in PR #4527:
URL: https://github.com/apache/hadoop/pull/4527#discussion_r1024579513


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -455,6 +385,10 @@ private class Connection extends Thread {
         Consumer<Connection> removeMethod) {
       this.remoteId = remoteId;
       this.server = remoteId.getAddress();
+      this.rpcRequestThread = new Thread(new RpcRequestSender(),
+          "IPC Parameter Sending Thread for " + remoteId);
+      this.rpcRequestThread.setDaemon(true);
+      this.rpcRequestThread.start();

Review Comment:
   Yeah, I moved the thread start to the top of the run method in the Connection thread.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org