[GitHub] [incubator-hudi] leesf commented on issue #1130: [HUDI-445]Refactor the codes based on scala codestyle BlockImportChecker rule

[GitBox <gi...@apache.org>]

leesf commented on issue #1130: [HUDI-445]Refactor the codes based on scala codestyle BlockImportChecker rule
URL: https://github.com/apache/incubator-hudi/pull/1130#issuecomment-568810464
 
 
   @sev7e0 Hi, thanks for opening this PR and welcome aboard, right now the IDEA will merge relative imports in block automatically, e.g. `import org.apache.spark.sql.{DataFrame, SQLContext, SaveMode}` in `HoodieSparkSqlWriter.scala`, it is very convenient. However, if we enable the BlockImportChecker rule, we may need fix it manually, which would waste some time for developers, a related disscussion would be found https://lists.apache.org/thread.html/d966752dcabd3305a888785944cd1ac2985b17e48d10d1c1abbca1dd%40%3Cdev.hudi.apache.org%3E, So IMHO we would keep the rule as it is before finding a better solution, WDYT? would close the PR and you would work on other scala codestyle rule if you are insterested :) . CC @lamber-ken FYI.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services