[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2266: SOLR-15120 Reduce duplicated core creation work

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #2266:
URL: https://github.com/apache/lucene-solr/pull/2266#discussion_r567274859



##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -3187,20 +3186,29 @@ public void cleanupOldIndexDirectories(boolean reload) {
     }
   }
 
-  @SuppressWarnings({"rawtypes"})
-  private static final Map implicitPluginsInfo = (Map) Utils.fromJSONResource("ImplicitPlugins.json");
+  private static final class ImplicitHolder {

Review comment:
       It appears this is here to lazy-load?  But why lazy-load (added complexity of ImplicitHolder wrapper) -- this cost is eventually inescapable since these are needed to load any core, not some obscure/optional feature.
   @madrob 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org