You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/09/03 09:08:13 UTC
[GitHub] [rocketmq-client-go] hnlq715 opened a new issue #721: feat: use sendMsgTimeout option for sendSync
hnlq715 opened a new issue #721:
URL: https://github.com/apache/rocketmq-client-go/issues/721
Currently it‘s simply hard code...
https://github.com/apache/rocketmq-client-go/blob/29d789edcaa3408e569e96e76bd71591ee66dbe7/producer/producer.go#L206-L210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] yuanmoon commented on issue #721: feat: use sendMsgTimeout option for sendSync
Posted by GitBox <gi...@apache.org>.
yuanmoon commented on issue #721:
URL: https://github.com/apache/rocketmq-client-go/issues/721#issuecomment-998764210
@wenfengwang
For this code segment, the hard code of request timeout is also used.
https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/consumer/offset_store.go#L357-L361
I find that the object doesn't have property for request timeout, which I think should be added.
https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/consumer/offset_store.go#L224-L230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] yuanmoon edited a comment on issue #721: feat: use sendMsgTimeout option for sendSync
Posted by GitBox <gi...@apache.org>.
yuanmoon edited a comment on issue #721:
URL: https://github.com/apache/rocketmq-client-go/issues/721#issuecomment-998780708
Many similar places can be found through global code search. Mainly involves the calling cases of the following two functions.
https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/internal/client.go#L141-L142
https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/internal/client.go#L145-L146
If I want to fix this issue and optimize code, I‘m not sure that it's necessary or not to have a unified standard of request timeout and set different default values according to different usage cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] yuanmoon commented on issue #721: feat: use sendMsgTimeout option for sendSync
Posted by GitBox <gi...@apache.org>.
yuanmoon commented on issue #721:
URL: https://github.com/apache/rocketmq-client-go/issues/721#issuecomment-998767181
Here is another code segment and has the same problem that the object doesn't have property for request timeout.
https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/admin/admin.go#L111-L112
https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/admin/admin.go#L41-L43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] yuanmoon commented on issue #721: feat: use sendMsgTimeout option for sendSync
Posted by GitBox <gi...@apache.org>.
yuanmoon commented on issue #721:
URL: https://github.com/apache/rocketmq-client-go/issues/721#issuecomment-998774760
The code segment in consumer/consumer.go also uses hard code.
https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/consumer/consumer.go#L587-L590
https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/consumer/consumer.go#L614-L619
https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/consumer/option.go#L27-L109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] yuanmoon commented on issue #721: feat: use sendMsgTimeout option for sendSync
Posted by GitBox <gi...@apache.org>.
yuanmoon commented on issue #721:
URL: https://github.com/apache/rocketmq-client-go/issues/721#issuecomment-998780708
Many similar places can be found through global code search. Mainly involves the calling cases of the following two functions
https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/internal/client.go#L141-L142
https://github.com/apache/rocketmq-client-go/blob/82dcf51c7c9bcec25a29e9617da61089db44b16d/internal/client.go#L145-L146
If I want to fix this issue and optimize code, I‘m not sure that it's necessary or not to have a unified standard of request timeout and set different default values according to different usage cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org