You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/10/10 11:21:40 UTC
[GitHub] [lucene-solr] barrotsteindev commented on a change in pull request #1970: SOLR-14869: do not add deleted docs in child doc transformer
barrotsteindev commented on a change in pull request #1970:
URL: https://github.com/apache/lucene-solr/pull/1970#discussion_r502779832
##########
File path: solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformer.java
##########
@@ -126,6 +128,12 @@ public void transform(SolrDocument rootDoc, int rootDocId) {
continue;
}
+ // check whether doc is "live"
+ if (liveDocs != null && !liveDocs.get(docId)) {
Review comment:
Oh oops, my bad.
Fixed and added your suggestion to the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org