You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/08/23 22:14:08 UTC
Review Request 68493: Avoided unnecessary copies in
`Resources::parse()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68493/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Avoided unnecessary copies by iterating using references
and using move when possible.
Diffs
-----
src/common/resources.cpp 0110c0ee3e810ad1c29dfa5507b13ebd5d0222a2
src/v1/resources.cpp 228a7327ffe7934d37b56ee67b8be9ae1e119ca8
Diff: https://reviews.apache.org/r/68493/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68493: Avoided unnecessary copies in
`Resources::parse()`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68493/#review207846
-----------------------------------------------------------
Bad patch!
Reviews applied: [68493, 68490, 68489]
Failed command: python support/apply-reviews.py -n -r 68489
Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-08-24 01:26:57 URL:https://reviews.apache.org/r/68489/diff/raw/ [2534/2534] -> "68489.patch" [1]
error: missing binary patch data for '3rdparty/boost-1.65.0.tar.gz'
error: binary patch does not apply to '3rdparty/boost-1.65.0.tar.gz'
error: 3rdparty/boost-1.65.0.tar.gz: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/23167/console
- Mesos Reviewbot
On Aug. 23, 2018, 10:14 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68493/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 10:14 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Avoided unnecessary copies by iterating using references
> and using move when possible.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 0110c0ee3e810ad1c29dfa5507b13ebd5d0222a2
> src/v1/resources.cpp 228a7327ffe7934d37b56ee67b8be9ae1e119ca8
>
>
> Diff: https://reviews.apache.org/r/68493/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68493: Avoided unnecessary copies in
`Resources::parse()`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68493/#review208287
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 23, 2018, 10:14 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68493/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 10:14 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Avoided unnecessary copies by iterating using references
> and using move when possible.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 0110c0ee3e810ad1c29dfa5507b13ebd5d0222a2
> src/v1/resources.cpp 228a7327ffe7934d37b56ee67b8be9ae1e119ca8
>
>
> Diff: https://reviews.apache.org/r/68493/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68493: Avoided unnecessary copies in
`Resources::parse()`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68493/#review207840
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 68489.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 68489`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2228/mesos-review-68493
Relevant logs:
- [apply-review-68489.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2228/mesos-review-68493/logs/apply-review-68489.log):
```
error: missing binary patch data for '3rdparty/boost-1.65.0.tar.gz'
error: binary patch does not apply to '3rdparty/boost-1.65.0.tar.gz'
error: 3rdparty/boost-1.65.0.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On Aug. 23, 2018, 3:14 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68493/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 3:14 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Avoided unnecessary copies by iterating using references
> and using move when possible.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 0110c0ee3e810ad1c29dfa5507b13ebd5d0222a2
> src/v1/resources.cpp 228a7327ffe7934d37b56ee67b8be9ae1e119ca8
>
>
> Diff: https://reviews.apache.org/r/68493/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>