You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/25 08:47:37 UTC

[GitHub] [incubator-doris] jacktengg opened a new pull request, #9771: [improvement] Show detail status code string for BE http api

jacktengg opened a new pull request, #9771:
URL: https://github.com/apache/incubator-doris/pull/9771

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Failure message for BE http api does not show detail status code:
   ```
       "status": "Fail",
       "msg": ""
   }
   ```
   Improved to:
   ```
   {
       "status": "Not found",
       "msg": "Tablet not found. tablet_id=1202"
   }
   ```
   
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9771: [improvement] Show detail status code string for BE http api

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9771:
URL: https://github.com/apache/incubator-doris/pull/9771#issuecomment-1138234832

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9771: [improvement] Show detail status code string for BE http api

Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9771:
URL: https://github.com/apache/incubator-doris/pull/9771#discussion_r881545905


##########
be/src/util/json_util.cpp:
##########
@@ -32,11 +32,7 @@ std::string to_json(const Status& status) {
     writer.StartObject();
     // status
     writer.Key("status");
-    if (status.ok()) {

Review Comment:
   Hi jack, I think we could move to_json(Status& status) method to  common/status.h since there is only one method in this file and it is related with common/status.
   And also you  could remove json_util_test.h because we could not ensure that the error message always the same with the expected string.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yiguolei merged pull request #9771: [improvement] Show detail status code string for BE http api

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9771:
URL: https://github.com/apache/incubator-doris/pull/9771


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9771: [improvement] Show detail status code string for BE http api

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9771:
URL: https://github.com/apache/incubator-doris/pull/9771#issuecomment-1138234797

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org