[GitHub] [lucene] dweiss commented on a change in pull request #108: LUCENE-9897 Change dependency checking mechanism to use gradle checksum verification

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r624560350



##########
File path: gradle/validation/jar-checks.gradle
##########
@@ -242,62 +206,14 @@ subprojects {
     }
   }
 
-  licenses.dependsOn validateJarChecksums, validateJarLicenses
+  licenses.dependsOn validateJarLicenses
 }
 
 // Add top-project level tasks validating dangling files
 // and regenerating dependency checksums.
 
 configure(project(":lucene")) {
   def validationTasks = subprojects.collectMany { it.tasks.matching { it.name == "licenses" } }
-  def jarInfoTasks = subprojects.collectMany { it.tasks.matching { it.name == "collectJarInfos" } }
-
-  // Update dependency checksums.
-  task updateLicenses() {

Review comment:
       Thanks. But does it mean that if we run some other task that pulls dependencies outside of check's scope the build will fail then?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org