You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/04 17:15:57 UTC
[GitHub] [incubator-inlong] leosanqing opened a new pull request, #4511: [INLONG-4510][Manager] Remove GsonUtils,InlongParser,Gson dependency
leosanqing opened a new pull request, #4511:
URL: https://github.com/apache/incubator-inlong/pull/4511
### Prepare a Pull Request
[INLONG-4510][Manager] Remove GsonUtils,InlongParser,Gson dependency
- Fixes #4510
### Motivation
- InlongPaser parsing is too cumbersome
- Gson can be replaced by Jackson
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
Remove GsonUtils,InlongParser,Gson dependency
### Verifying this change
- [ ] This change added tests and can be verified as follows:
- InlongGroupImplTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #4511: [INLONG-4510][Manager] Remove GsonUtils, InlongParser, and Gson dependency
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4511:
URL: https://github.com/apache/incubator-inlong/pull/4511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4511: [INLONG-4510][Manager] Remove GsonUtils, InlongParser, and Gson dependency
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4511:
URL: https://github.com/apache/incubator-inlong/pull/4511#discussion_r889688440
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/workflow/form/NewGroupProcessForm.java:
##########
@@ -33,6 +34,7 @@
*/
@Data
@EqualsAndHashCode(callSuper = false)
+@JsonIgnoreProperties(ignoreUnknown = true)
Review Comment:
Why add this annotation here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4511: [INLONG-4510][Manager] Remove GsonUtils,InlongParser,Gson dependency
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4511:
URL: https://github.com/apache/incubator-inlong/pull/4511#discussion_r889634822
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/impl/InlongGroupImpl.java:
##########
@@ -267,7 +269,7 @@ private InlongGroupContext generateSnapshot() {
logList.stream().filter(x -> StringUtils.isNotEmpty(x.getComponentName()))
.forEach(streamLog -> {
String componentName = streamLog.getComponentName();
- String log = JsonUtils.toJsonString(streamLog);
+ String log = toJsonString(streamLog);
Review Comment:
No need to use a static import, just use `JsonUtils.toJsonString` is more clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org