You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Sahlberg <da...@gmail.com> on 2024/07/06 17:55:55 UTC
Re: svn commit: r1918965 - /subversion/branches/cmake/CMakeLists.txt
Just a minor nit!
Den lör 6 juli 2024 kl 14:27 skrev <ri...@apache.org>:
> Author: rinrab
> Date: Sat Jul 6 12:27:21 2024
> New Revision: 1918965
>
> URL: http://svn.apache.org/viewvc?rev=1918965&view=rev
> Log:
> On the 'cmake' branch: Read and setup Subversion package version.
>
> * CMakeLists.txt
> (version): Do little magic with CMake and regexes to read the version.
> (project): Setup VERSION field.
>
> Modified:
> subversion/branches/cmake/CMakeLists.txt
>
This also seems to add an option to build SVNXX:
@@ -83,6 +96,8 @@ if(SVN_BUILD_SHARED_RA)
> message(FATAL_ERROR "SVN_BUILD_SHARED_RA not yet supported")
> endif()
>
> +option(SVN_BUILD_SVNXX "Enable compilation of the C++ bindings (requires
> C++)" OFF)
> +
> # Setup modules path
>
> list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/build/cmake")
>
Should be mentioned in the log message, I think.
Kind regards,
Daniel
Re: svn commit: r1918965 - /subversion/branches/cmake/CMakeLists.txt
Posted by Daniel Sahlberg <da...@gmail.com>.
Den lör 6 juli 2024 kl 21:17 skrev Timofei Zhakov <ti...@chemodax.net>:
> Hello,
>
> Thanks for the notice!
>
> I was experimenting with SVNXX and forgot to revert this change :)
>
No problem! I hope you don't mind I edited the log message of this revision
to mention the future reversal. I find this quite useful in understanding
the code later on.
Kind regards,
Daniel
Re: svn commit: r1918965 - /subversion/branches/cmake/CMakeLists.txt
Posted by Daniel Sahlberg <da...@gmail.com>.
Den lör 6 juli 2024 kl 21:17 skrev Timofei Zhakov <ti...@chemodax.net>:
> Hello,
>
> Thanks for the notice!
>
> I was experimenting with SVNXX and forgot to revert this change :)
>
No problem! I hope you don't mind I edited the log message of this revision
to mention the future reversal. I find this quite useful in understanding
the code later on.
Kind regards,
Daniel
Re: svn commit: r1918965 - /subversion/branches/cmake/CMakeLists.txt
Posted by Timofei Zhakov <ti...@chemodax.net>.
On Sat, Jul 6, 2024 at 7:57 PM Daniel Sahlberg
<da...@gmail.com> wrote:
>
> Just a minor nit!
>
> Den lör 6 juli 2024 kl 14:27 skrev <ri...@apache.org>:
>>
>> Author: rinrab
>> Date: Sat Jul 6 12:27:21 2024
>> New Revision: 1918965
>>
>> URL: http://svn.apache.org/viewvc?rev=1918965&view=rev
>> Log:
>> On the 'cmake' branch: Read and setup Subversion package version.
>>
>> * CMakeLists.txt
>> (version): Do little magic with CMake and regexes to read the version.
>> (project): Setup VERSION field.
>>
>> Modified:
>> subversion/branches/cmake/CMakeLists.txt
>
>
> This also seems to add an option to build SVNXX:
>
> @@ -83,6 +96,8 @@ if(SVN_BUILD_SHARED_RA)
>>
>> message(FATAL_ERROR "SVN_BUILD_SHARED_RA not yet supported")
>> endif()
>>
>> +option(SVN_BUILD_SVNXX "Enable compilation of the C++ bindings (requires C++)" OFF)
>> +
>> # Setup modules path
>>
>> list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/build/cmake")
>
>
> Should be mentioned in the log message, I think.
>
> Kind regards,
> Daniel
>
Hello,
Thanks for the notice!
I was experimenting with SVNXX and forgot to revert this change :)
Reverted in revision 1918977.
--
Timofei Zhakov
Re: svn commit: r1918965 - /subversion/branches/cmake/CMakeLists.txt
Posted by Timofei Zhakov <ti...@chemodax.net>.
On Sat, Jul 6, 2024 at 7:57 PM Daniel Sahlberg
<da...@gmail.com> wrote:
>
> Just a minor nit!
>
> Den lör 6 juli 2024 kl 14:27 skrev <ri...@apache.org>:
>>
>> Author: rinrab
>> Date: Sat Jul 6 12:27:21 2024
>> New Revision: 1918965
>>
>> URL: http://svn.apache.org/viewvc?rev=1918965&view=rev
>> Log:
>> On the 'cmake' branch: Read and setup Subversion package version.
>>
>> * CMakeLists.txt
>> (version): Do little magic with CMake and regexes to read the version.
>> (project): Setup VERSION field.
>>
>> Modified:
>> subversion/branches/cmake/CMakeLists.txt
>
>
> This also seems to add an option to build SVNXX:
>
> @@ -83,6 +96,8 @@ if(SVN_BUILD_SHARED_RA)
>>
>> message(FATAL_ERROR "SVN_BUILD_SHARED_RA not yet supported")
>> endif()
>>
>> +option(SVN_BUILD_SVNXX "Enable compilation of the C++ bindings (requires C++)" OFF)
>> +
>> # Setup modules path
>>
>> list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/build/cmake")
>
>
> Should be mentioned in the log message, I think.
>
> Kind regards,
> Daniel
>
Hello,
Thanks for the notice!
I was experimenting with SVNXX and forgot to revert this change :)
Reverted in revision 1918977.
--
Timofei Zhakov