You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/24 18:20:34 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
EricGao888 opened a new pull request, #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733
## Purpose of the pull request
* Add missing default values in dolphinscheduler_env.sh
* Update related docs
* This PR closes: #9675
## Brief change log
* Already Described above
## Verify this pull request
* Verified by manual tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109336727
@EricGao888 Finally, we have an agreement. please see https://github.com/apache/dolphinscheduler/issues/9675#issuecomment-1108041268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r858784720
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -168,13 +171,20 @@ mysql> GRANT ALL PRIVILEGES ON dolphinscheduler.* TO '{user}'@'%';
mysql> CREATE USER '{user}'@'localhost' IDENTIFIED BY '{password}';
mysql> GRANT ALL PRIVILEGES ON dolphinscheduler.* TO '{user}'@'localhost';
mysql> FLUSH PRIVILEGES;
-```
+```
-Change the username and password in `tools/conf/application.yaml` to {user} and {password} you set in the previous step.
+Then, modify `./bin/env/dolphinscheduler_env.sh` to use mysql, change {user} and {password} to what you set in the previous step.
-Then, modify `tools/bin/dolphinscheduler_env.sh`, set mysql as default database `export DATABASE=${DATABASE:-mysql}`.
+```shell
+export DATABASE=${DATABASE:-mysql}
+export SPRING_PROFILES_ACTIVE=${DATABASE}
+export SPRING_DATASOURCE_DRIVER_CLASS_NAME=com.mysql.jdbc.Driver
Review Comment:
Fixed in the latest commit. Thx for the review : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109840622
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=9733)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9733&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9733&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109243811
> Hi @EricGao888 , please resolve conficts.
@SbloodyS Thx for the reminder! I'm a bit confused about what to do in this PR, since we no more need add default values to `dolphinscheduler_env.sh` as explained in this comment: https://github.com/apache/dolphinscheduler/issues/9675#issuecomment-1107996038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS merged pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
SbloodyS merged PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r859350986
##########
dolphinscheduler-tools/src/main/bin/create-schema.sh:
##########
@@ -18,7 +18,8 @@
BIN_DIR=$(dirname $0)
DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/../..; pwd)}
-source "$DOLPHINSCHEDULER_HOME/tools/bin/dolphinscheduler_env.sh"
+
+source "$DOLPHINSCHEDULER_HOME/bin/env/dolphinscheduler_env.sh"
Review Comment:
I do not think it will cause the failed. I will restart the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109887005
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=9733)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9733&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9733&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109464938
> Yes. But some of the default value in `dolphinscheduler_env.sh` still missing. @EricGao888
>
> https://github.com/apache/dolphinscheduler/blob/637028735dbf8a78efa63cf8358d2bead7bb5c6e/script/env/dolphinscheduler_env.sh#L24-L27
Sure I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r859358024
##########
dolphinscheduler-tools/src/main/bin/create-schema.sh:
##########
@@ -18,7 +18,8 @@
BIN_DIR=$(dirname $0)
DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/../..; pwd)}
-source "$DOLPHINSCHEDULER_HOME/tools/bin/dolphinscheduler_env.sh"
+
+source "$DOLPHINSCHEDULER_HOME/bin/env/dolphinscheduler_env.sh"
Review Comment:
@github +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r859315632
##########
dolphinscheduler-tools/src/main/bin/create-schema.sh:
##########
@@ -18,7 +18,8 @@
BIN_DIR=$(dirname $0)
DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/../..; pwd)}
-source "$DOLPHINSCHEDULER_HOME/tools/bin/dolphinscheduler_env.sh"
+
+source "$DOLPHINSCHEDULER_HOME/bin/env/dolphinscheduler_env.sh"
Review Comment:
I think it is a good idea to remove the assembly config in case users get confused. Will fix it in the next commit. : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r859355600
##########
dolphinscheduler-tools/src/main/bin/create-schema.sh:
##########
@@ -18,7 +18,8 @@
BIN_DIR=$(dirname $0)
DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/../..; pwd)}
-source "$DOLPHINSCHEDULER_HOME/tools/bin/dolphinscheduler_env.sh"
+
+source "$DOLPHINSCHEDULER_HOME/bin/env/dolphinscheduler_env.sh"
Review Comment:
> @EricGao888 It's E2E build failed. Maybe it's the problem with GitHub Actions since it can't guarantee 99.99% stability...
could I @github at this time？ 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1107895718
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=9733)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9733&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9733&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r859314938
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -115,26 +97,47 @@ deployUser="dolphinscheduler"
### Modify `dolphinscheduler_env.sh`
-File `dolphinscheduler_env.sh` describes the database configuration of DolphinScheduler, which in the path `bin/env/dolphinscheduler_env.sh`
-and some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`. You could ignore the
-task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
+File `./bin/env/dolphinscheduler_env.sh` describes the following configurations:
+* Database configuration of DolphinScheduler, see [Initialize the Database](#initialize-the-database) for detailed instructions.
+* Some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`.
+* Registry center `zookeeper`.
+* Server related configuration, such as cache type, timezone, etc.
+
+You could ignore the task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
related configurations based on your environment.
-```sh
+```shell
# JAVA_HOME, will use it to start DolphinScheduler server
-export JAVA_HOME=${JAVA_HOME:-/custom/path}
+export JAVA_HOME=${JAVA_HOME:-/opt/soft/java}
# Database related configuration, set database type, username and password
export DATABASE=${DATABASE:-postgresql}
export SPRING_PROFILES_ACTIVE=${DATABASE}
export SPRING_DATASOURCE_DRIVER_CLASS_NAME=org.postgresql.Driver
-export SPRING_DATASOURCE_URL="jdbc:postgresql://127.0.0.1:5432/dolphinscheduler"
-export SPRING_DATASOURCE_USERNAME="username"
-export SPRING_DATASOURCE_PASSWORD="password"
+export SPRING_DATASOURCE_URL=jdbc:postgresql://127.0.0.1:5432/dolphinscheduler
+export SPRING_DATASOURCE_USERNAME={user}
+export SPRING_DATASOURCE_PASSWORD={password}
Review Comment:
I think it may be able to remind users of replacing them with their own. I can change it to string value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r858767146
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -168,13 +171,20 @@ mysql> GRANT ALL PRIVILEGES ON dolphinscheduler.* TO '{user}'@'%';
mysql> CREATE USER '{user}'@'localhost' IDENTIFIED BY '{password}';
mysql> GRANT ALL PRIVILEGES ON dolphinscheduler.* TO '{user}'@'localhost';
mysql> FLUSH PRIVILEGES;
-```
+```
-Change the username and password in `tools/conf/application.yaml` to {user} and {password} you set in the previous step.
+Then, modify `./bin/env/dolphinscheduler_env.sh` to use mysql, change {user} and {password} to what you set in the previous step.
-Then, modify `tools/bin/dolphinscheduler_env.sh`, set mysql as default database `export DATABASE=${DATABASE:-mysql}`.
+```shell
+export DATABASE=${DATABASE:-mysql}
+export SPRING_PROFILES_ACTIVE=${DATABASE}
+export SPRING_DATASOURCE_DRIVER_CLASS_NAME=com.mysql.jdbc.Driver
Review Comment:
The mysql package version used by ds is ```8.0.16```. Therefore we should use ```com.mysql.cj.jdbc.Driver``` instead of ```com.mysql.jdbc.Driver```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109710638
I added missing default values in `dolphinscheduler_env.sh`, updated related docs and fixed minor issue in `update-schema.sh` following PR #9726, PTAL when you have time. Thx! @zhongjiajie @SbloodyS
BTW, not sure why some E2E tests failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109461609
Yes. But some of the default value in ```dolphinscheduler_env.sh``` still missing. @EricGao888
https://github.com/apache/dolphinscheduler/blob/637028735dbf8a78efa63cf8358d2bead7bb5c6e/script/env/dolphinscheduler_env.sh#L24-L27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r859354383
##########
dolphinscheduler-tools/src/main/bin/create-schema.sh:
##########
@@ -18,7 +18,8 @@
BIN_DIR=$(dirname $0)
DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/../..; pwd)}
-source "$DOLPHINSCHEDULER_HOME/tools/bin/dolphinscheduler_env.sh"
+
+source "$DOLPHINSCHEDULER_HOME/bin/env/dolphinscheduler_env.sh"
Review Comment:
@EricGao888 It's E2E build failed. Maybe it's the problem with GitHub Actions since it can't guarantee 99.99% stability...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109806344
> `script/env/dolphinscheduler_env.sh` will overwrite the default setting of stanalone server. Standalone server starts with `H2` database by default. That's why E2E tests failed.
>
> We may find a way bypass it. Otherwise, restore `script/env/dolphinscheduler_env.sh` as it is. @EricGao888
@SbloodyS I think it may not be easy to find a way to bypass it. Considering we already have default values in `application.yaml` and also provider users with examples in docs in this PR, should we just restore `script/env/dolphinscheduler_env.sh` and leave those default values blank? https://github.com/apache/dolphinscheduler/blob/52b188b3479dadf54d160bacfe5b19c3fd82d038/dolphinscheduler-tools/src/main/resources/application.yaml#L17-L24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1110498171
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=9733)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9733&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9733&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r859312555
##########
dolphinscheduler-tools/src/main/bin/create-schema.sh:
##########
@@ -18,7 +18,8 @@
BIN_DIR=$(dirname $0)
DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/../..; pwd)}
-source "$DOLPHINSCHEDULER_HOME/tools/bin/dolphinscheduler_env.sh"
+
+source "$DOLPHINSCHEDULER_HOME/bin/env/dolphinscheduler_env.sh"
Review Comment:
if we do not use `dolphinscheduler_env.sh` file anymore, we should also remove the assembly config https://github.com/apache/dolphinscheduler/blob/de50f43de63e42488cb38169cd56fba77dd24fc6/dolphinscheduler-tools/src/main/assembly/dolphinscheduler-tools.xml#L41-L49
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -115,26 +97,47 @@ deployUser="dolphinscheduler"
### Modify `dolphinscheduler_env.sh`
-File `dolphinscheduler_env.sh` describes the database configuration of DolphinScheduler, which in the path `bin/env/dolphinscheduler_env.sh`
-and some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`. You could ignore the
-task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
+File `./bin/env/dolphinscheduler_env.sh` describes the following configurations:
+* Database configuration of DolphinScheduler, see [Initialize the Database](#initialize-the-database) for detailed instructions.
+* Some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`.
+* Registry center `zookeeper`.
+* Server related configuration, such as cache type, timezone, etc.
+
+You could ignore the task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
related configurations based on your environment.
-```sh
+```shell
# JAVA_HOME, will use it to start DolphinScheduler server
-export JAVA_HOME=${JAVA_HOME:-/custom/path}
+export JAVA_HOME=${JAVA_HOME:-/opt/soft/java}
# Database related configuration, set database type, username and password
export DATABASE=${DATABASE:-postgresql}
export SPRING_PROFILES_ACTIVE=${DATABASE}
export SPRING_DATASOURCE_DRIVER_CLASS_NAME=org.postgresql.Driver
-export SPRING_DATASOURCE_URL="jdbc:postgresql://127.0.0.1:5432/dolphinscheduler"
-export SPRING_DATASOURCE_USERNAME="username"
-export SPRING_DATASOURCE_PASSWORD="password"
+export SPRING_DATASOURCE_URL=jdbc:postgresql://127.0.0.1:5432/dolphinscheduler
+export SPRING_DATASOURCE_USERNAME={user}
+export SPRING_DATASOURCE_PASSWORD={password}
Review Comment:
why we use `{user}` and `{password}` instead of exactly string value
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -115,26 +97,47 @@ deployUser="dolphinscheduler"
### Modify `dolphinscheduler_env.sh`
-File `dolphinscheduler_env.sh` describes the database configuration of DolphinScheduler, which in the path `bin/env/dolphinscheduler_env.sh`
-and some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`. You could ignore the
-task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
+File `./bin/env/dolphinscheduler_env.sh` describes the following configurations:
+* Database configuration of DolphinScheduler, see [Initialize the Database](#initialize-the-database) for detailed instructions.
Review Comment:
Add one more blank line will be more confortable
```suggestion
* Database configuration of DolphinScheduler, see [Initialize the Database](#initialize-the-database) for detailed instructions.
```
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -115,26 +97,47 @@ deployUser="dolphinscheduler"
### Modify `dolphinscheduler_env.sh`
-File `dolphinscheduler_env.sh` describes the database configuration of DolphinScheduler, which in the path `bin/env/dolphinscheduler_env.sh`
-and some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`. You could ignore the
-task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
+File `./bin/env/dolphinscheduler_env.sh` describes the following configurations:
+* Database configuration of DolphinScheduler, see [Initialize the Database](#initialize-the-database) for detailed instructions.
Review Comment:
Same as ZH docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1107894534
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9733?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9733](https://codecov.io/gh/apache/dolphinscheduler/pull/9733?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (637258c) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/5657cb9aecfd2ce6b87fb5340439cdf4c1c2bb9a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5657cb9) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev #9733 +/- ##
============================================
- Coverage 40.02% 40.01% -0.01%
+ Complexity 4474 4473 -1
============================================
Files 835 835
Lines 33573 33573
Branches 3714 3714
============================================
- Hits 13436 13434 -2
- Misses 18884 18889 +5
+ Partials 1253 1250 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/9733?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/dolphinscheduler/remote/utils/Host.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0hvc3QuamF2YQ==) | `37.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `52.11% <0.00%> (-1.41%)` | :arrow_down: |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9733/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `83.33% <0.00%> (+5.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9733?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9733?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5657cb9...637258c](https://codecov.io/gh/apache/dolphinscheduler/pull/9733?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109214547
Hi @EricGao888 , please resolve conficts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109458466
> @EricGao888 Finally, we have an agreement. please see [#9675 (comment)](https://github.com/apache/dolphinscheduler/issues/9675#issuecomment-1108041268)
@SbloodyS I just checked the latest code, it seems this feature has been implemented by PR #9726
https://github.com/apache/dolphinscheduler/blob/637028735dbf8a78efa63cf8358d2bead7bb5c6e/script/dolphinscheduler-daemon.sh#L37-L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109700526
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=9733)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=9733&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9733&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=9733&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109813976
@EricGao888 I think these example is enough for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109849556
> @EricGao888 I think these examples is enough for users.
Done, CI looks good now. : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r859347146
##########
dolphinscheduler-tools/src/main/bin/create-schema.sh:
##########
@@ -18,7 +18,8 @@
BIN_DIR=$(dirname $0)
DOLPHINSCHEDULER_HOME=${DOLPHINSCHEDULER_HOME:-$(cd $BIN_DIR/../..; pwd)}
-source "$DOLPHINSCHEDULER_HOME/tools/bin/dolphinscheduler_env.sh"
+
+source "$DOLPHINSCHEDULER_HOME/bin/env/dolphinscheduler_env.sh"
Review Comment:
@SbloodyS @zhongjiajie E2E tests failed. May I ask is it caused by the removal of assembly config? Is there any way to bypass it? Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r859316768
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -115,26 +97,47 @@ deployUser="dolphinscheduler"
### Modify `dolphinscheduler_env.sh`
-File `dolphinscheduler_env.sh` describes the database configuration of DolphinScheduler, which in the path `bin/env/dolphinscheduler_env.sh`
-and some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`. You could ignore the
-task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
+File `./bin/env/dolphinscheduler_env.sh` describes the following configurations:
+* Database configuration of DolphinScheduler, see [Initialize the Database](#initialize-the-database) for detailed instructions.
+* Some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`.
+* Registry center `zookeeper`.
+* Server related configuration, such as cache type, timezone, etc.
+
+You could ignore the task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
related configurations based on your environment.
-```sh
+```shell
# JAVA_HOME, will use it to start DolphinScheduler server
-export JAVA_HOME=${JAVA_HOME:-/custom/path}
+export JAVA_HOME=${JAVA_HOME:-/opt/soft/java}
# Database related configuration, set database type, username and password
export DATABASE=${DATABASE:-postgresql}
export SPRING_PROFILES_ACTIVE=${DATABASE}
export SPRING_DATASOURCE_DRIVER_CLASS_NAME=org.postgresql.Driver
-export SPRING_DATASOURCE_URL="jdbc:postgresql://127.0.0.1:5432/dolphinscheduler"
-export SPRING_DATASOURCE_USERNAME="username"
-export SPRING_DATASOURCE_PASSWORD="password"
+export SPRING_DATASOURCE_URL=jdbc:postgresql://127.0.0.1:5432/dolphinscheduler
+export SPRING_DATASOURCE_USERNAME={user}
+export SPRING_DATASOURCE_PASSWORD={password}
Review Comment:
maybe you're right, keep it pls 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r859315142
##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -115,26 +97,47 @@ deployUser="dolphinscheduler"
### Modify `dolphinscheduler_env.sh`
-File `dolphinscheduler_env.sh` describes the database configuration of DolphinScheduler, which in the path `bin/env/dolphinscheduler_env.sh`
-and some tasks which need external dependencies or libraries such as `JAVA_HOME` and `SPARK_HOME`. You could ignore the
-task external dependencies if you do not use those tasks, but you have to change `JAVA_HOME`, registry center and database
+File `./bin/env/dolphinscheduler_env.sh` describes the following configurations:
+* Database configuration of DolphinScheduler, see [Initialize the Database](#initialize-the-database) for detailed instructions.
Review Comment:
Sure I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1109774591
```script/env/dolphinscheduler_env.sh``` will overwrite the default setting of stanalone server. Standalone server starts with ```H2``` database by default. That's why E2E tests failed.
We may find a way by pass it. Otherwise, restore ```script/env/dolphinscheduler_env.sh``` as it is. @EricGao888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#issuecomment-1110445834
I am take a look on this PR now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org