You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/06/19 13:53:30 UTC
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1650: code polish
codecov-commenter edited a comment on pull request #1650:
URL: https://github.com/apache/incubator-shenyu/pull/1650#issuecomment-864408760
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1650?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1650](https://codecov.io/gh/apache/incubator-shenyu/pull/1650?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4d749b) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/3a83f5d0017a08e26631982eb63d4b6ff196bb72?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a83f5d) will **decrease** coverage by `0.72%`.
> The diff coverage is `46.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1650 +/- ##
============================================
- Coverage 63.33% 62.61% -0.73%
+ Complexity 2245 2216 -29
============================================
Files 456 456
Lines 9560 9450 -110
Branches 973 974 +1
============================================
- Hits 6055 5917 -138
- Misses 3016 3042 +26
- Partials 489 491 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1650?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/admin/controller/AppAuthController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9BcHBBdXRoQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...enyu/admin/controller/DashboardUserController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9EYXNoYm9hcmRVc2VyQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...pache/shenyu/admin/controller/IndexController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/MetaDataController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9NZXRhRGF0YUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/PlatformController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbGF0Zm9ybUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ache/shenyu/admin/controller/PluginController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5Db250cm9sbGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...apache/shenyu/admin/controller/RuleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SdWxlQ29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...he/shenyu/admin/controller/SelectorController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TZWxlY3RvckNvbnRyb2xsZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [.../shenyu/admin/controller/ShenyuDictController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TaGVueXVEaWN0Q29udHJvbGxlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...ache/shenyu/admin/exception/ExceptionHandlers.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZXhjZXB0aW9uL0V4Y2VwdGlvbkhhbmRsZXJzLmphdmE=) | `30.55% <0.00%> (-42.78%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1650/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1650?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1650?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3a83f5d...c4d749b](https://codecov.io/gh/apache/incubator-shenyu/pull/1650?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org