You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/08 22:04:32 UTC
[kudu-CR](branch-1.4.x) Temporary workaround for KUDU-1959 (race when selecting rowsets)
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7122
Change subject: Temporary workaround for KUDU-1959 (race when selecting rowsets)
......................................................................
Temporary workaround for KUDU-1959 (race when selecting rowsets)
As described in the JIRA, there is a race by which multiple MM threads
can race to pick the same rowsets for compaction. Rather than crash when
hitting this bug, it is safe to simply abort that compaction attempt.
The MM will warn about the compaction failure and try again.
This is a temporary workround for the 1.4 release since the issue was
recently reported in the wild on the user list.
Change-Id: I9db313849176e1bf05636d969fafb1682e6d78de
Reviewed-on: http://gerrit.cloudera.org:8080/7120
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 8be2a59103da46472062f47f89efa6e1bddd0a5c)
---
M src/kudu/tablet/tablet.cc
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/7122/1
--
To view, visit http://gerrit.cloudera.org:8080/7122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9db313849176e1bf05636d969fafb1682e6d78de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.4.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.4.x) Temporary workaround for KUDU-1959 (race when selecting rowsets)
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Temporary workaround for KUDU-1959 (race when selecting rowsets)
......................................................................
Temporary workaround for KUDU-1959 (race when selecting rowsets)
As described in the JIRA, there is a race by which multiple MM threads
can race to pick the same rowsets for compaction. Rather than crash when
hitting this bug, it is safe to simply abort that compaction attempt.
The MM will warn about the compaction failure and try again.
This is a temporary workround for the 1.4 release since the issue was
recently reported in the wild on the user list.
Change-Id: I9db313849176e1bf05636d969fafb1682e6d78de
Reviewed-on: http://gerrit.cloudera.org:8080/7120
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 8be2a59103da46472062f47f89efa6e1bddd0a5c)
Reviewed-on: http://gerrit.cloudera.org:8080/7122
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/tablet/tablet.cc
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9db313849176e1bf05636d969fafb1682e6d78de
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.4.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.4.x) Temporary workaround for KUDU-1959 (race when selecting rowsets)
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Temporary workaround for KUDU-1959 (race when selecting rowsets)
......................................................................
Patch Set 1: Code-Review+2
Forwarding +2 since this is a clean cherry pick and I'm the RM :)
--
To view, visit http://gerrit.cloudera.org:8080/7122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9db313849176e1bf05636d969fafb1682e6d78de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.4.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No