More on tomcat4 build.xml files

[Bob Jamison <rj...@lincom-asg.com>]

Thanks for getting those fixes in so quickly.  Now
the "build" part is working, but  now that I am
reaching "build dist" , it seems to require a couple
more amendments to the build.xml files:

1.  On line 88 in <toplevel>/build.xml, the line says

<copydir src="${servletapi.dist}/docs/api"

It should be

<copydir src="${servletapi.home}/docs/api"

2.  In catalina/build.xml, to do the entire Javadoc tree,
line 93 needs to know about external classes; from

classpath="${regexp.jar}:${servlet.jar}:${catalina.build}/classes"

to

classpath="${xerces.jar}:${jcert.jar}:${jsse.jar}:${jnet.jar}:${regexp.jar}:${servlet.jar}:${catalina.build}/classes"

It is somewhat long, but it works.  Maybe a variable like ${all-jars}
would be handy?
Thanks.


Bob Jamison
LinCom Corp

Re: More on tomcat4 build.xml files

[Bob Jamison <rj...@lincom-asg.com>]

Pierre Delisle wrote:

> Thanks for pointing out these. All fixes are in.
>
>     -- Pierre

Excellent!  The builds are looking pretty good.



Bob

Re: More on tomcat4 build.xml files

[Pierre Delisle <pi...@sun.com>]

Bob,

Thanks for pointing out these. All fixes are in.

    -- Pierre

Bob Jamison wrote:
> 
> Also, in <toplevel> build.sh , line 66:
> 
> CP=$ANT_HOME/lib/ant.jar:$JAVA_HOME/lib/tools.jar:$XERCES_HOME\xerces.jar
> 
> should be
> 
> CP=$ANT_HOME/lib/ant.jar:$JAVA_HOME/lib/tools.jar:$XERCES_HOME/xerces.jar
> 
> to work on both Windows and Unix.
> 
> <jasper>/build.xml's Javadoc section, the same as Catalina,
> needs to know more about the external libs,  line 70:
> 
> classpath="${servlet.jar}:${jasper.build}/classes"
> 
> to
> 
> classpath="${xerces.jar}:${servlet.jar}:${jasper.build}/classes"
> 
> Also, since Jasper uses $JAVA_HOME/lib/tools.jar, maybe this
> would be a nice addition to the "Derived Property Values" section:
> 
> <property name="tools.jar"      value="${java.home}/lib/tools.jar"/>
> 
> Whatever a "java.home" variable would actually be, then on 70:
> 
> classpath="${tools.jar}:${xerces.jar}:${servlet.jar}:${jasper.build}/classes"
> 
> Bob
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org

Re: More on tomcat4 build.xml files

[Bob Jamison <rj...@lincom-asg.com>]

Also, in <toplevel> build.sh , line 66:

CP=$ANT_HOME/lib/ant.jar:$JAVA_HOME/lib/tools.jar:$XERCES_HOME\xerces.jar

should be

CP=$ANT_HOME/lib/ant.jar:$JAVA_HOME/lib/tools.jar:$XERCES_HOME/xerces.jar

to work on both Windows and Unix.





<jasper>/build.xml's Javadoc section, the same as Catalina,
needs to know more about the external libs,  line 70:

classpath="${servlet.jar}:${jasper.build}/classes"

to

classpath="${xerces.jar}:${servlet.jar}:${jasper.build}/classes"


Also, since Jasper uses $JAVA_HOME/lib/tools.jar, maybe this
would be a nice addition to the "Derived Property Values" section:

<property name="tools.jar"      value="${java.home}/lib/tools.jar"/>

Whatever a "java.home" variable would actually be, then on 70:

classpath="${tools.jar}:${xerces.jar}:${servlet.jar}:${jasper.build}/classes"



Bob