patch for org.apache.jackrabbit.webdav.xmlDomUtil

[John Langley <la...@gmail.com>]

Attached is a patch I'd like to propose for DomUtils.java
It does two things.
1) it adds a "catch" for an exception that can occur when xerces is on your
classpath and the createFactory() method runs (at init time). Apparently the
xerces version of DocumentBuilderFactory doesn't support this method.
2) it adds a method that allows us to inject a customized version of the
DocumentBuilderFactory. You may want to inject a DocumentBuilderFactory if
you want to make have a local catalog resolver used for xml validation. In
practice we use this technique to address this issue:
http://www.w3.org/blog/systeam/2008/02/08/w3c_s_excessive_dtd_traffic

I'd love feedback by a commiter if something needs to be changed and then it
would be great if someone would submit it for me.

Thanks

-- Langley

Re: Fwd: patch for org.apache.jackrabbit.webdav.xmlDomUtil

[John Langley <la...@gmail.com>]

Thanks Angela, will do.
-- Langley

On Thu, Feb 24, 2011 at 7:53 AM, Angela Schreiber <an...@adobe.com> wrote:

> hi john
>
> can you create an issue and attach the patch (checking the
> the radio button that your patch is intended for inclusion.
>
> someone will then take a look at it, provide feedback and
> possibly commit the patch.
>
> thanks
> angela
>
>
> On 2/24/11 1:30 PM, John Langley wrote:
>
>> Sorry for the repost... I'm resending because from my side it ~looks
>> like~ the email below
>> never got sent to the mailing list.
>>
>> Thanks for feedback, I'm looking forward to see if this patch can make
>> it into 2.2.5.
>> I've run all the test suite with it in against a local build from head
>> as of yesterday.
>>
>> -- Langley
>>
>> ---------- Forwarded message ----------
>> From: *John Langley* <langleyatwork@gmail.com
>> <ma...@gmail.com>>
>> Date: Wed, Feb 23, 2011 at 11:29 AM
>> Subject: patch for org.apache.jackrabbit.webdav.xmlDomUtil
>> To: dev@jackrabbit.apache.org <ma...@jackrabbit.apache.org>
>>
>>
>> Attached is a patch I'd like to propose for DomUtils.java
>> It does two things.
>> 1) it adds a "catch" for an exception that can occur when xerces is on
>> your classpath and the createFactory() method runs (at init time).
>> Apparently the xerces version of DocumentBuilderFactory doesn't support
>> this method.
>> 2) it adds a method that allows us to inject a customized version of the
>> DocumentBuilderFactory. You may want to inject a DocumentBuilderFactory
>> if you want to make have a local catalog resolver used for xml
>> validation. In practice we use this technique to address this issue:
>> http://www.w3.org/blog/systeam/2008/02/08/w3c_s_excessive_dtd_traffic
>>
>> I'd love feedback by a commiter if something needs to be changed and
>> then it would be great if someone would submit it for me.
>>
>> Thanks
>>
>> -- Langley
>>
>>

Re: Fwd: patch for org.apache.jackrabbit.webdav.xmlDomUtil

[Angela Schreiber <an...@adobe.com>]

hi john

can you create an issue and attach the patch (checking the
the radio button that your patch is intended for inclusion.

someone will then take a look at it, provide feedback and
possibly commit the patch.

thanks
angela

On 2/24/11 1:30 PM, John Langley wrote:
> Sorry for the repost... I'm resending because from my side it ~looks
> like~ the email below
> never got sent to the mailing list.
>
> Thanks for feedback, I'm looking forward to see if this patch can make
> it into 2.2.5.
> I've run all the test suite with it in against a local build from head
> as of yesterday.
>
> -- Langley
>
> ---------- Forwarded message ----------
> From: *John Langley* <langleyatwork@gmail.com
> <ma...@gmail.com>>
> Date: Wed, Feb 23, 2011 at 11:29 AM
> Subject: patch for org.apache.jackrabbit.webdav.xmlDomUtil
> To: dev@jackrabbit.apache.org <ma...@jackrabbit.apache.org>
>
>
> Attached is a patch I'd like to propose for DomUtils.java
> It does two things.
> 1) it adds a "catch" for an exception that can occur when xerces is on
> your classpath and the createFactory() method runs (at init time).
> Apparently the xerces version of DocumentBuilderFactory doesn't support
> this method.
> 2) it adds a method that allows us to inject a customized version of the
> DocumentBuilderFactory. You may want to inject a DocumentBuilderFactory
> if you want to make have a local catalog resolver used for xml
> validation. In practice we use this technique to address this issue:
> http://www.w3.org/blog/systeam/2008/02/08/w3c_s_excessive_dtd_traffic
>
> I'd love feedback by a commiter if something needs to be changed and
> then it would be great if someone would submit it for me.
>
> Thanks
>
> -- Langley
>

Fwd: patch for org.apache.jackrabbit.webdav.xmlDomUtil

[John Langley <la...@gmail.com>]

Sorry for the repost... I'm resending because from my side it ~looks like~
the email below
never got sent to the mailing list.

Thanks for feedback, I'm looking forward to see if this patch can make it
into 2.2.5.
I've run all the test suite with it in against a local build from head as of
yesterday.

-- Langley

---------- Forwarded message ----------
From: John Langley <la...@gmail.com>
Date: Wed, Feb 23, 2011 at 11:29 AM
Subject: patch for org.apache.jackrabbit.webdav.xmlDomUtil
To: dev@jackrabbit.apache.org


Attached is a patch I'd like to propose for DomUtils.java
It does two things.
1) it adds a "catch" for an exception that can occur when xerces is on your
classpath and the createFactory() method runs (at init time). Apparently the
xerces version of DocumentBuilderFactory doesn't support this method.
2) it adds a method that allows us to inject a customized version of the
DocumentBuilderFactory. You may want to inject a DocumentBuilderFactory if
you want to make have a local catalog resolver used for xml validation. In
practice we use this technique to address this issue:
http://www.w3.org/blog/systeam/2008/02/08/w3c_s_excessive_dtd_traffic

I'd love feedback by a commiter if something needs to be changed and then it
would be great if someone would submit it for me.

Thanks

-- Langley