You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/15 14:14:43 UTC
[GitHub] [arrow] andygrove opened a new pull request #7970: ARROW-9754: [Rust] [DataFusion] Implement async in DataFusion traits [WIP]
andygrove opened a new pull request #7970:
URL: https://github.com/apache/arrow/pull/7970
This bulids on https://github.com/apache/arrow/pull/7969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #7970: ARROW-9754: [Rust] [DataFusion] Implement async in DataFusion traits [WIP]
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #7970:
URL: https://github.com/apache/arrow/pull/7970#issuecomment-674432567
I plan to review this carefully tomorrow morning US Eastern time
On Sat, Aug 15, 2020 at 10:20 AM Andy Grove <no...@github.com>
wrote:
> @alamb <https://github.com/alamb> @jorgecarleitao
> <https://github.com/jorgecarleitao> fyi
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/arrow/pull/7970#issuecomment-674404189>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADXZMNFVI2IVTLERKG7IF3SA2KUDANCNFSM4QAJNDXQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove closed pull request #7970: ARROW-9754: [Rust] [DataFusion] Implement async in DataFusion traits [WIP]
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #7970:
URL: https://github.com/apache/arrow/pull/7970
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #7970: ARROW-9754: [Rust] [DataFusion] Implement async in DataFusion traits [WIP]
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #7970:
URL: https://github.com/apache/arrow/pull/7970#issuecomment-674446596
Closing this one too since it builds on the previous flawed PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7970: ARROW-9754: [Rust] [DataFusion] Implement async in DataFusion traits [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7970:
URL: https://github.com/apache/arrow/pull/7970#issuecomment-674404108
https://issues.apache.org/jira/browse/ARROW-9754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on a change in pull request #7970: ARROW-9754: [Rust] [DataFusion] Implement async in DataFusion traits [WIP]
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #7970:
URL: https://github.com/apache/arrow/pull/7970#discussion_r471021201
##########
File path: rust/datafusion/Cargo.toml
##########
@@ -53,6 +53,8 @@ rustyline = {version = "6.0", optional = true}
crossbeam = "0.7"
paste = "0.1"
num_cpus = "1.13.0"
+async-executor = "0.1.2"
Review comment:
I wonder why you went with async-executor and not tokio? I hear tokio is all the rage and I am not sure that you can have two different async executors play nicely with each other (and thus this change may make datafusion incompatible with tokio...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #7970: ARROW-9754: [Rust] [DataFusion] Implement async in DataFusion traits [WIP]
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #7970:
URL: https://github.com/apache/arrow/pull/7970#issuecomment-674404189
@alamb @jorgecarleitao fyi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org