You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@stdcxx.apache.org by "Travis Vitek (JIRA)" <ji...@apache.org> on 2008/01/29 16:41:34 UTC
[jira] Created: (STDCXX-716) update rw_locales() to accept query
strings, update tests
update rw_locales() to accept query strings, update tests
---------------------------------------------------------
Key: STDCXX-716
URL: https://issues.apache.org/jira/browse/STDCXX-716
Project: C++ Standard Library
Issue Type: Sub-task
Components: Test Driver
Reporter: Travis Vitek
Fix For: 4.2.1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (STDCXX-716) update rw_locales() to accept query
strings, update tests
Posted by "Travis Vitek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Travis Vitek closed STDCXX-716.
-------------------------------
Closing resolved and verified 4.2.1 issue.
> update rw_locales() to accept query strings, update tests
> ---------------------------------------------------------
>
> Key: STDCXX-716
> URL: https://issues.apache.org/jira/browse/STDCXX-716
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: Test Driver
> Affects Versions: 4.2.0
> Reporter: Travis Vitek
> Assignee: Travis Vitek
> Fix For: 4.2.1
>
> Original Estimate: 4h
> Time Spent: 29h
> Remaining Estimate: 11h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STDCXX-716) update rw_locales() to accept query
strings, update tests
Posted by "Martin Sebor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Sebor updated STDCXX-716:
--------------------------------
Affects Version/s: 4.2.0
Set Affects Version/s to 4.2.0.
> update rw_locales() to accept query strings, update tests
> ---------------------------------------------------------
>
> Key: STDCXX-716
> URL: https://issues.apache.org/jira/browse/STDCXX-716
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: Test Driver
> Affects Versions: 4.2.0
> Reporter: Travis Vitek
> Assignee: Travis Vitek
> Fix For: 4.2.1
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (STDCXX-716) update rw_locales() to
accept query strings, update tests
Posted by "Travis Vitek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583820#action_12583820 ]
vitek edited comment on STDCXX-716 at 3/31/08 1:13 PM:
--------------------------------------------------------------
Okay, then that simplifies the expressions. I've been doing some testing and it may not be necessary to reduce this further than what I posted above. The test 22.locale.ctype.toupper now runs in about 3 minutes for an 11s build on AIX. Obviously we can reduce the time it takes by further limiting the locales tested. So should we still reduce this further?
One thing that we might consider doing would be to change the {{count}} parameter that is passet to {{rw_query_locales()}} to be the maximum number of matches for a single pattern instead of the maximum total number of matches. Just an idea.
was (Author: vitek):
Okay, then that simplifies the expressions. I've been doing some testing and it may not be necessary to reduce this further than what I posted above. The test 22.locale.ctype.toupper now runs in about 3 minutes for an 11s build on AIX. Obviously we can reduce the time it takes by further limiting the locales tested. So should we still reduce this down?
One thing that we might consider doing would be to change the count parameter that is passet to {{{rw_query_locales()}}} to be the maximum number of matches for a single pattern instead of the maximum total number of matches. Just an idea.
> update rw_locales() to accept query strings, update tests
> ---------------------------------------------------------
>
> Key: STDCXX-716
> URL: https://issues.apache.org/jira/browse/STDCXX-716
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: Test Driver
> Affects Versions: 4.2.0
> Reporter: Travis Vitek
> Assignee: Travis Vitek
> Fix For: 4.2.1
>
> Original Estimate: 4h
> Time Spent: 28h
> Remaining Estimate: 12h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (STDCXX-716) update rw_locales() to accept query
strings, update tests
Posted by "Travis Vitek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Travis Vitek resolved STDCXX-716.
---------------------------------
Resolution: Fixed
This is implemented and working on trunk. Will close when merged to 4.2.x.
> update rw_locales() to accept query strings, update tests
> ---------------------------------------------------------
>
> Key: STDCXX-716
> URL: https://issues.apache.org/jira/browse/STDCXX-716
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: Test Driver
> Affects Versions: 4.2.0
> Reporter: Travis Vitek
> Assignee: Travis Vitek
> Fix For: 4.2.1
>
> Original Estimate: 4h
> Time Spent: 29h
> Remaining Estimate: 11h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STDCXX-716) update rw_locales() to accept query
strings, update tests
Posted by "Travis Vitek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583759#action_12583759 ]
Travis Vitek commented on STDCXX-716:
-------------------------------------
Martin suggests we test against locales that match the following pattern
{noformat}
{{en-US,de-*,fr-*,es-*}-*-{ISO-8859-*,UTF-8,CP125?},
{ja-JP-*-{EUC-JP,SHIFT_JIS,UTF-8,CP125?}},
{zh-*-*-{GB*,UTF-8,CP125?}},
{ru-*-*-{KOI*,UTF-8,CP125?}}}
{noformat}
> update rw_locales() to accept query strings, update tests
> ---------------------------------------------------------
>
> Key: STDCXX-716
> URL: https://issues.apache.org/jira/browse/STDCXX-716
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: Test Driver
> Affects Versions: 4.2.0
> Reporter: Travis Vitek
> Assignee: Travis Vitek
> Fix For: 4.2.1
>
> Original Estimate: 4h
> Time Spent: 28h
> Remaining Estimate: 12h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (STDCXX-716) update rw_locales() to accept query
strings, update tests
Posted by "Travis Vitek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Travis Vitek reassigned STDCXX-716:
-----------------------------------
Assignee: Travis Vitek
> update rw_locales() to accept query strings, update tests
> ---------------------------------------------------------
>
> Key: STDCXX-716
> URL: https://issues.apache.org/jira/browse/STDCXX-716
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: Test Driver
> Reporter: Travis Vitek
> Assignee: Travis Vitek
> Fix For: 4.2.1
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STDCXX-716) update rw_locales() to accept query
strings, update tests
Posted by "Farid Zaripov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589936#action_12589936 ]
Farid Zaripov commented on STDCXX-716:
--------------------------------------
Merged in 4.2.x branch thus: http://svn.apache.org/viewvc?view=rev&revision=648752
> update rw_locales() to accept query strings, update tests
> ---------------------------------------------------------
>
> Key: STDCXX-716
> URL: https://issues.apache.org/jira/browse/STDCXX-716
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: Test Driver
> Affects Versions: 4.2.0
> Reporter: Travis Vitek
> Assignee: Travis Vitek
> Fix For: 4.2.1
>
> Original Estimate: 4h
> Time Spent: 29h
> Remaining Estimate: 11h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STDCXX-716) update rw_locales() to accept query
strings, update tests
Posted by "Martin Sebor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583773#action_12583773 ]
Martin Sebor commented on STDCXX-716:
-------------------------------------
IIUC, the pattern will match each locale for many countries (e.g., {{de_*}} will match the German locale for Austria, Belgium, Germany, Luxembourg, and Switzerland). I think testing at most one of these is sufficient. Also, I think that alternating the encodings (e.g., exercising {{de_DE.ISO-8859-1}} and {{fr_FR.UTF-8}} rather than exhaustively testing all combinations of locales and encodings) should be sufficient for many (most?) tests.
> update rw_locales() to accept query strings, update tests
> ---------------------------------------------------------
>
> Key: STDCXX-716
> URL: https://issues.apache.org/jira/browse/STDCXX-716
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: Test Driver
> Affects Versions: 4.2.0
> Reporter: Travis Vitek
> Assignee: Travis Vitek
> Fix For: 4.2.1
>
> Original Estimate: 4h
> Time Spent: 28h
> Remaining Estimate: 12h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STDCXX-716) update rw_locales() to accept query
strings, update tests
Posted by "Travis Vitek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582816#action_12582816 ]
Travis Vitek commented on STDCXX-716:
-------------------------------------
Still need to decide upon a set of locales to use for each test, and start using new {{rw_query_locale()}} function.
> update rw_locales() to accept query strings, update tests
> ---------------------------------------------------------
>
> Key: STDCXX-716
> URL: https://issues.apache.org/jira/browse/STDCXX-716
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: Test Driver
> Affects Versions: 4.2.0
> Reporter: Travis Vitek
> Assignee: Travis Vitek
> Fix For: 4.2.1
>
> Original Estimate: 4h
> Time Spent: 8h
> Remaining Estimate: 0h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STDCXX-716) update rw_locales() to accept query
strings, update tests
Posted by "Travis Vitek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582815#action_12582815 ]
Travis Vitek commented on STDCXX-716:
-------------------------------------
Committed to trunk in [r642006|http://svn.apache.org/viewvc?view=rev&revision=642006].
> update rw_locales() to accept query strings, update tests
> ---------------------------------------------------------
>
> Key: STDCXX-716
> URL: https://issues.apache.org/jira/browse/STDCXX-716
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: Test Driver
> Affects Versions: 4.2.0
> Reporter: Travis Vitek
> Assignee: Travis Vitek
> Fix For: 4.2.1
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STDCXX-716) update rw_locales() to accept query
strings, update tests
Posted by "Travis Vitek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/STDCXX-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583820#action_12583820 ]
Travis Vitek commented on STDCXX-716:
-------------------------------------
Okay, then that simplifies the expressions. I've been doing some testing and it may not be necessary to reduce this further than what I posted above. The test 22.locale.ctype.toupper now runs in about 3 minutes for an 11s build on AIX. Obviously we can reduce the time it takes by further limiting the locales tested. So should we still reduce this down?
One thing that we might consider doing would be to change the count parameter that is passet to {{{rw_query_locales()}}} to be the maximum number of matches for a single pattern instead of the maximum total number of matches. Just an idea.
> update rw_locales() to accept query strings, update tests
> ---------------------------------------------------------
>
> Key: STDCXX-716
> URL: https://issues.apache.org/jira/browse/STDCXX-716
> Project: C++ Standard Library
> Issue Type: Sub-task
> Components: Test Driver
> Affects Versions: 4.2.0
> Reporter: Travis Vitek
> Assignee: Travis Vitek
> Fix For: 4.2.1
>
> Original Estimate: 4h
> Time Spent: 28h
> Remaining Estimate: 12h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.