[GitHub] [trafficserver] maskit commented on a diff in pull request #9294: Don't initialize the member variables of HistoryEntry and SourceLocation

[GitBox <gi...@apache.org>]

maskit commented on code in PR #9294:
URL: https://github.com/apache/trafficserver/pull/9294#discussion_r1073995304


##########
include/tscore/SourceLocation.h:
##########
@@ -34,9 +34,9 @@
 class SourceLocation
 {
 public:
-  const char *file = nullptr;
-  const char *func = nullptr;
-  int line         = 0;
+  const char *file;
+  const char *func;
+  int line;
 
   SourceLocation()                          = default;
   SourceLocation(const SourceLocation &rhs) = default;

Review Comment:
   Unfortunately those causes compile errors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org