Is the --file argument wrongly named ?

[Francois Beausoleil <fb...@users.sourceforge.net>]

Hi,

I usually used the -F parameter, but today I decided that I wanted the
long form (don't ask why :))

So, I ran svn help commit:
...
Valid options:
  -m [--message] arg       : specify commit message ARG
  -F [--file] arg          : read data from file ARG
...

Is it me, or does --file not describe the real intent of the parameter ? 
Shouldn't it be named --message-file or something ?  I know it's pretty
late in the game to notice this, but anyway, I just wanted to bring this
to the attention of everyone, in case it wasfelt that this is important
enough.

I did a search in the commands, and I found the following:
commit, copy, delete, import, mkdir, move:
--file is used as the commit message

propset:
--file is used as the property's value

In my opinion, --file should be split in two:  one for the commit message
(--message-file or similar), and one for the property value (--prop-file
or similar).

Bye !
François
Developer of Java Gui Builder
http://jgb.sourceforge.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Is the --file argument wrongly named ?

["C. Michael Pilato" <cm...@collab.net>]

"Francois Beausoleil" <fb...@users.sourceforge.net> writes:

> In my opinion, --file should be split in two:  one for the commit message
> (--message-file or similar), and one for the property value (--prop-file
> or similar).

Oh, I agree entirely.  Someday we're going to want to allow remote
propsets (currently disabled), which is a form of commit, and that
means we'll want a syntax like 'svn propset mypropname --data-file
/path/to/prop/contents --log-message-file /path/to/my/commit/msg'.

I still think -F should be used for log messages, but it's long form
needs a new name.  And then, as you noted, propsets need their own
long option (no need for short-form there, IMO).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org