You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Pil0tXia (via GitHub)" <gi...@apache.org> on 2024/01/18 10:08:31 UTC
Re: [PR] [ISSUE #4750] Replace sun.net.httpserver.HttpServer to use netty server (eventmesh)
Pil0tXia commented on code in PR #4739:
URL: https://github.com/apache/eventmesh/pull/4739#discussion_r1457212354
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/HttpResponseUtils.java:
##########
@@ -45,6 +45,10 @@ public static HttpResponse createInternalServerError() {
return new DefaultFullHttpResponse(HttpVersion.HTTP_1_1, HttpResponseStatus.INTERNAL_SERVER_ERROR);
}
+ public static HttpResponse create404NotFound() {
+ return new DefaultFullHttpResponse(HttpVersion.HTTP_1_1, HttpResponseStatus.NOT_FOUND);
+ }
+
Review Comment:
This method is duplicate with `createNotFound()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org