You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/21 08:54:08 UTC

[GitHub] [cloudstack] utchoang opened a new pull request #6142: UI: Remove unused dependencies and fix travis build

utchoang opened a new pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142


   ### Description
   
   This PR related https://github.com/apache/cloudstack/issues/5950
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   ![image](https://user-images.githubusercontent.com/13766648/159229648-8f21675a-ff35-47ec-8d67-0137c5381b3d.png)
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on a change in pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#discussion_r831698242



##########
File path: ui/package.json
##########
@@ -86,10 +84,8 @@
     "eslint-plugin-vue": "^7.0.0",
     "less": "^3.0.4",
     "less-loader": "^5.0.0",
-    "node-sass": "^4.0.0",

Review comment:
       I found that removing it has no effect on the build process. I'm not sure about this, can keep it if we want.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1074776987


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1073716381


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1076962222


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6142 (SL-JID-1291)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1073721442


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6142 (SL-JID-1279)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#discussion_r831276623



##########
File path: ui/package.json
##########
@@ -86,10 +84,8 @@
     "eslint-plugin-vue": "^7.0.0",
     "less": "^3.0.4",
     "less-loader": "^5.0.0",
-    "node-sass": "^4.0.0",

Review comment:
       Don't we need node-sass for building css etc?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1073717375


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez closed pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez closed pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1077343636


   Thanks @utchoang can you re-run the npm install/build etc to regenerate and ensure that the package-lock.json is correct and updated as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1077535701


   @blueorangutan package
   @blueorangutan ui
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1077536081






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#discussion_r831276310



##########
File path: ui/package.json
##########
@@ -52,11 +52,9 @@
     "npm-check-updates": "^6.0.1",
     "nprogress": "^0.2.0",
     "vue": "^3.2.31",
-    "vue-clipboard2": "^0.3.1",
     "vue-cropper": "^1.0.2",
     "vue-i18n": "^9.1.6",
     "vue-loader": "^16.2.0",
-    "vue-ls": "^3.2.2",

Review comment:
       aren't we using localstorage now?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on a change in pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#discussion_r831097909



##########
File path: ui/package-lock.json
##########
@@ -4774,20 +4774,31 @@
       }
     },
     "antd-theme-generator": {
-      "version": "1.2.11",
-      "resolved": "https://registry.npmjs.org/antd-theme-generator/-/antd-theme-generator-1.2.11.tgz",
-      "integrity": "sha512-7A3lXyLb7eD7MXK7aSgZZ4DxQEdhZwyKhzIm70orUZPQJ8N8TWhZphyOWSGCe8yUqGQhi8PcpM2pLmTriZyKBw==",
+      "version": "1.2.10",
+      "resolved": "https://registry.npmjs.org/antd-theme-generator/-/antd-theme-generator-1.2.10.tgz",
+      "integrity": "sha512-Eh/5bJP7SejZCTOg1Rq4WB9PkfGXEKo3XWRCFj6Cf1Zsp76Jc9eiXUOijQ2YMtkhLMN2RJOnaNR+OOSpfAonDw==",
       "requires": {
         "glob": "^7.1.3",
         "hash.js": "^1.1.5",
         "less": "^3.9.0",
-        "less-bundle-promise": "^1.0.11",
+        "less-bundle-promise": "^1.0.7",

Review comment:
       For the 1.0.11 version, it gives an error as shown in the screenshot. You can test run locally




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1074777661


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1076959520


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#discussion_r830936670



##########
File path: ui/package-lock.json
##########
@@ -4774,20 +4774,31 @@
       }
     },
     "antd-theme-generator": {
-      "version": "1.2.11",
-      "resolved": "https://registry.npmjs.org/antd-theme-generator/-/antd-theme-generator-1.2.11.tgz",
-      "integrity": "sha512-7A3lXyLb7eD7MXK7aSgZZ4DxQEdhZwyKhzIm70orUZPQJ8N8TWhZphyOWSGCe8yUqGQhi8PcpM2pLmTriZyKBw==",
+      "version": "1.2.10",
+      "resolved": "https://registry.npmjs.org/antd-theme-generator/-/antd-theme-generator-1.2.10.tgz",
+      "integrity": "sha512-Eh/5bJP7SejZCTOg1Rq4WB9PkfGXEKo3XWRCFj6Cf1Zsp76Jc9eiXUOijQ2YMtkhLMN2RJOnaNR+OOSpfAonDw==",
       "requires": {
         "glob": "^7.1.3",
         "hash.js": "^1.1.5",
         "less": "^3.9.0",
-        "less-bundle-promise": "^1.0.11",
+        "less-bundle-promise": "^1.0.7",

Review comment:
       latest version not used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#discussion_r831276966



##########
File path: ui/package.json
##########
@@ -86,10 +84,8 @@
     "eslint-plugin-vue": "^7.0.0",
     "less": "^3.0.4",
     "less-loader": "^5.0.0",
-    "node-sass": "^4.0.0",
     "sass": "^1.49.9",
     "sass-loader": "^8.0.2",
-    "uglifyjs-webpack-plugin": "^2.2.0",

Review comment:
       Don't we want to minimise/compress the UI build?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1076959699


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on a change in pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on a change in pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#discussion_r833563794



##########
File path: ui/package.json
##########
@@ -86,10 +84,8 @@
     "eslint-plugin-vue": "^7.0.0",
     "less": "^3.0.4",
     "less-loader": "^5.0.0",
-    "node-sass": "^4.0.0",

Review comment:
       @utchoang I suppose it's worth checking where/how it is used, esp for any `less` and related stylesheet processing. (it's possible it doesn't happen or is required for build, but maybe for development)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on a change in pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#discussion_r831699849



##########
File path: ui/package.json
##########
@@ -86,10 +84,8 @@
     "eslint-plugin-vue": "^7.0.0",
     "less": "^3.0.4",
     "less-loader": "^5.0.0",
-    "node-sass": "^4.0.0",
     "sass": "^1.49.9",
     "sass-loader": "^8.0.2",
-    "uglifyjs-webpack-plugin": "^2.2.0",

Review comment:
       My apologies, I tried to delete it to check the audit fix but made a mistake. Will add it back in.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on a change in pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#discussion_r831697645



##########
File path: ui/package.json
##########
@@ -52,11 +52,9 @@
     "npm-check-updates": "^6.0.1",
     "nprogress": "^0.2.0",
     "vue": "^3.2.31",
-    "vue-clipboard2": "^0.3.1",
     "vue-cropper": "^1.0.2",
     "vue-i18n": "^9.1.6",
     "vue-loader": "^16.2.0",
-    "vue-ls": "^3.2.2",

Review comment:
       No. We using vue-web-storage instead of vue-ls. Because vue-ls not support Vue 3




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1074780392


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6142 (SL-JID-1284)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1077555932


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2976


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6142: UI: Remove unused dependencies and fix travis build

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6142:
URL: https://github.com/apache/cloudstack/pull/6142#issuecomment-1077541358


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6142 (SL-JID-1295)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org