You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/05 13:06:45 UTC

[GitHub] [skywalking] gnr163 opened a new issue #5243: question about no statement with slowStatement

gnr163 opened a new issue #5243:
URL: https://github.com/apache/skywalking/issues/5243


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [x] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
    The code [MultiScopesAnalysisListener.java@213     statement.setStatement("[No statement]/" + sourceBuilder.getDestEndpointName());] 
   sourceBuilder.getDestEndpointName() is null, why not use span.getOperationName() ? Is this a deliberate design ?
   
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   
   - Which company or project?
   
   - What happen?
   If possible, provide a way for reproducing the error. e.g. demo application, component version.
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #5243: question about no statement with slowStatement

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5243:
URL: https://github.com/apache/skywalking/issues/5243


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #5243: question about no statement with slowStatement

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5243:
URL: https://github.com/apache/skywalking/issues/5243


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5243: question about no statement with slowStatement

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5243:
URL: https://github.com/apache/skywalking/issues/5243#issuecomment-669184684


   OK, I think I get your point, that is a bug when updating 8.x


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5243: question about no statement with slowStatement

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5243:
URL: https://github.com/apache/skywalking/issues/5243#issuecomment-669185314


   Please submit a pull request to fix this. Should use `#getOperationName` of the span.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5243: question about no statement with slowStatement

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5243:
URL: https://github.com/apache/skywalking/issues/5243#issuecomment-669183893


   Read how we set the dest endpoint name, which is exactly the operation name. Please recheck.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng removed a comment on issue #5243: question about no statement with slowStatement

Posted by GitBox <gi...@apache.org>.
wu-sheng removed a comment on issue #5243:
URL: https://github.com/apache/skywalking/issues/5243#issuecomment-669183893


   Read how we set the dest endpoint name, which is exactly the operation name. Please recheck.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org