You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Bryan Pendleton <bp...@amberpoint.com> on 2006/10/26 22:25:56 UTC

Re: DERBY-1953 test patch.

>    It appears that Bernt has submitted an additional patch for MODE 
> DB2SQL removal from all tests with the exception of db2compatability and 
> the testing of DB2SQL as a keyword
> under DERBY-1953.

Thanks Yip! I'll have a look at Bernt's patch.

bryan

Re: DERBY-1953 test patch.

Posted by Bryan Pendleton <bp...@amberpoint.com>.
> Bryan is right. Changed UpgradeTester.java to take that into
> consideration. New patch uploaded.

Thanks Bernt! With your latest patch, the Upgrade test passes for me. +1 to commit.

thanks,

bryan

Re: DERBY-1953 test patch.

Posted by "Bernt M. Johnsen" <Be...@Sun.COM>.
>>>>>>>>>>>> Bryan Pendleton wrote (2006-10-26 17:43:45):
> >Good. I was planning on committing it soon since Knut Anders has
> >reviewed it. 
> 
> Hi Bernt,
> 
> With derby-1770-tests.diff applied to the current head of trunk, I
> get a failure in the upgrade_10_1_10_3 test.
> 
> I think that maybe the mode db2sql is still required when running
> in the 10.1 portion of the upgrade test, or something like that?

Bryan is right. Changed UpgradeTester.java to take that into
consideration. New patch uploaded.

(This comment added to JIRA issue and new patch uploaded)

> 
> I'll add this comment to the JIRA issue too, just copying the list cuz
> the Jira email is still down.
> 
> thanks,
> 
> bryan
> 

-- 
Bernt Marius Johnsen, Database Technology Group, 
Staff Engineer, Technical Lead Derby/Java DB
Sun Microsystems, Trondheim, Norway

Re: DERBY-1953 test patch.

Posted by Bryan Pendleton <bp...@amberpoint.com>.
> Good. I was planning on committing it soon since Knut Anders has
> reviewed it. 

Hi Bernt,

With derby-1770-tests.diff applied to the current head of trunk, I
get a failure in the upgrade_10_1_10_3 test.

I think that maybe the mode db2sql is still required when running
in the 10.1 portion of the upgrade test, or something like that?

I'll add this comment to the JIRA issue too, just copying the list cuz
the Jira email is still down.

thanks,

bryan

Re: DERBY-1953 test patch.

Posted by "Bernt M. Johnsen" <Be...@Sun.COM>.
>>>>>>>>>>>> Bryan Pendleton wrote (2006-10-26 13:25:56):
> >   It appears that Bernt has submitted an additional patch for MODE 
> >DB2SQL removal from all tests with the exception of db2compatability and 
> >the testing of DB2SQL as a keyword
> >under DERBY-1953.
> 
> Thanks Yip! I'll have a look at Bernt's patch.

Good. I was planning on committing it soon since Knut Anders has
reviewed it. But it's kind of hard to follow what's happening (e.g. I
did not notice that Knut Anders had reviewed it) when I don't get any
Jira-mail.

-- 
Bernt Marius Johnsen, Database Technology Group, 
Staff Engineer, Technical Lead Derby/Java DB
Sun Microsystems, Trondheim, Norway