You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "xxzuo (via GitHub)" <gi...@apache.org> on 2024/07/16 13:25:42 UTC

[PR] [Fix-14109] fix search-result item url [dolphinscheduler-website]

xxzuo opened a new pull request, #964:
URL: https://github.com/apache/dolphinscheduler-website/pull/964

   fix search-result item url
   fix https://github.com/apache/dolphinscheduler/issues/14108
   
   - The current item link:
   
   ![image](https://github.com/user-attachments/assets/ff4db60a-120c-4667-9c60-82d81800bc5d)
   ![image](https://github.com/user-attachments/assets/b04888a3-0afe-4456-8c61-3b43eb57f3df)
   
   
   Unable to jump to the target page
   
   
   - The Fix item link:
   ![image](https://github.com/user-attachments/assets/3ee668a8-763d-48a0-a29b-434a13a0a6c5)
   ![image](https://github.com/user-attachments/assets/65ee1721-c2d9-430e-90e3-8b47b50c0e7d)
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix] fix website search [dolphinscheduler-website]

Posted by "xxzuo (via GitHub)" <gi...@apache.org>.
xxzuo commented on code in PR #964:
URL: https://github.com/apache/dolphinscheduler-website/pull/964#discussion_r1679462237


##########
src/views/Documentation/SearchModal.jsx:
##########
@@ -1,7 +1,7 @@
 import { memo, useState, useEffect } from "react";
 import { Modal, Input, Button, Breadcrumb, Empty, Spin } from "antd";
 import { useParams } from "react-router-dom";
-import { getLinkFromLocation } from "./helpers";
+import {getSearchItemLinkFromLocation} from "./helpers";

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix] fix website search [dolphinscheduler-website]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #964:
URL: https://github.com/apache/dolphinscheduler-website/pull/964#discussion_r1679441060


##########
src/views/Documentation/SearchModal.jsx:
##########
@@ -1,7 +1,7 @@
 import { memo, useState, useEffect } from "react";
 import { Modal, Input, Button, Breadcrumb, Empty, Spin } from "antd";
 import { useParams } from "react-router-dom";
-import { getLinkFromLocation } from "./helpers";
+import {getSearchItemLinkFromLocation} from "./helpers";

Review Comment:
   Please format the code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix] fix website search [dolphinscheduler-website]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #964:
URL: https://github.com/apache/dolphinscheduler-website/pull/964


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org