[jira] Resolved: (THRIFT-905) Make haskell thrift bindings use automake to compile and install

["Anthony Molinaro (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anthony Molinaro resolved THRIFT-905.
-------------------------------------

      Assignee: Christian Lavoie  (was: Anthony Molinaro)
    Resolution: Fixed

Okay, commited with a minor change since it was still failing sometimes when you ran 'make maintainer-clean'  specifically if you didn't have haskell installed.  It looks like autconf runs maintainer-clean even when automake turns off a directory.  This makes some sense.   So what I changed is that RUNHASKELL is set to true if haskell is not found or turned off.  This then allows maintainer-clean to run without error at it runs 'true Setup.lhs clean' which just returns success.

One thing which is likely an issue to be addressed at some point is that I doubt 'make DESTDIR=/tmp install' will work, so people packaging with rpm/deb will most likely have to disable haskell until that is fixed, but not a big enough deal to stop inclusion (besides ruby also has this problem).

Christian, please close if you are satisfied.


> Make haskell thrift bindings use automake to compile and install
> ----------------------------------------------------------------
>
>                 Key: THRIFT-905
>                 URL: https://issues.apache.org/jira/browse/THRIFT-905
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Haskell - Compiler, Haskell - Library
>    Affects Versions: 0.5
>         Environment: Mac OS X 10.6, ghc 6.12.3 (haskell platform 2010.2)
> Darwin - 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> Glasgow Haskell Compiler, Version 6.12.3, for Haskell 98, stage 2 booted by GHC version 6.12.2
>            Reporter: Christian Lavoie
>            Assignee: Christian Lavoie
>             Fix For: 0.5
>
>         Attachments: thrift-automake-haskell-support.patch, v2-thrift-haskell-autotools.patch
>
>
> Makes automake call cabal to compile the haskell library. Not the prettiest, but allows (theoretical) support for non-ghc compilers.
> Needs to be applied with patch -p1; patch depends on https://issues.apache.org/jira/browse/THRIFT-901 due to existing brokenness in bindings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.