You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2017/01/12 09:46:48 UTC
Review Request 55446: Added common validation for IDs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55446/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, James Peach, and Joseph Wu.
Bugs: MESOS-6866
https://issues.apache.org/jira/browse/MESOS-6866
Repository: mesos
Description
-------
- The common validation logic is shared by the master and the agent.
Diffs
-----
src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c
src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c
src/common/validation.hpp PRE-CREATION
src/common/validation.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/55446/diff/
Testing
-------
make check
Tested with /r/55449/
Thanks,
Jiang Yan Xu
Re: Review Request 55446: Added common validation for IDs.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On Jan. 13, 2017, 10:50 a.m., Anindya Sinha wrote:
> > src/common/validation.cpp, line 36
> > <https://reviews.apache.org/r/55446/diff/1/?file=1603766#file1603766line36>
> >
> > Should we consider disallowing spaces as well? `iscntrl` includes tabs but do we want spaces to be included in the path?
IMO we should but we currently don't. This patch doesn't propose new rules. I was going to create a JIRA for some new rules but JIRA is down. :(
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55446/#review161560
-----------------------------------------------------------
On Jan. 12, 2017, 1:46 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55446/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 1:46 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-6866
> https://issues.apache.org/jira/browse/MESOS-6866
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - The common validation logic is shared by the master and the agent.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c
> src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c
> src/common/validation.hpp PRE-CREATION
> src/common/validation.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55446/diff/
>
>
> Testing
> -------
>
> make check
> Tested with /r/55449/
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 55446: Added common validation for IDs.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55446/#review161560
-----------------------------------------------------------
src/common/validation.cpp (line 36)
<https://reviews.apache.org/r/55446/#comment232848>
Should we consider disallowing spaces as well? `iscntrl` includes tabs but do we want spaces to be included in the path?
- Anindya Sinha
On Jan. 12, 2017, 9:46 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55446/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 9:46 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-6866
> https://issues.apache.org/jira/browse/MESOS-6866
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - The common validation logic is shared by the master and the agent.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c
> src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c
> src/common/validation.hpp PRE-CREATION
> src/common/validation.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55446/diff/
>
>
> Testing
> -------
>
> make check
> Tested with /r/55449/
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 55446: Added common validation for IDs.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55446/#review161430
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Jan. 12, 2017, 9:46 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55446/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 9:46 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-6866
> https://issues.apache.org/jira/browse/MESOS-6866
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - The common validation logic is shared by the master and the agent.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c
> src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c
> src/common/validation.hpp PRE-CREATION
> src/common/validation.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55446/diff/
>
>
> Testing
> -------
>
> make check
> Tested with /r/55449/
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 55446: Added common validation for IDs.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On Jan. 12, 2017, 1:43 p.m., James Peach wrote:
> > src/common/validation.hpp, line 34
> > <https://reviews.apache.org/r/55446/diff/1/?file=1603765#file1603765line34>
> >
> > Since this is never used externally, consider making it a local static helper/
This is used externally.
> On Jan. 12, 2017, 1:43 p.m., James Peach wrote:
> > src/common/validation.hpp, line 18
> > <https://reviews.apache.org/r/55446/diff/1/?file=1603765#file1603765line18>
> >
> > Should this be `__COMMON_VALIDATION_HPP__`?
It's not a requirement to match the file path but since I am putting the methods in the `common` namespace I guess I could use `__COMMON_VALIDATION_HPP__` here.
Another point is that perhaps we could move *some* of these (as a TODO) to `<mesos>/include/mesos/validation.hpp` for which we could use `__VALIDATION_HPP__`.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55446/#review161426
-----------------------------------------------------------
On Jan. 12, 2017, 1:46 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55446/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 1:46 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-6866
> https://issues.apache.org/jira/browse/MESOS-6866
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - The common validation logic is shared by the master and the agent.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c
> src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c
> src/common/validation.hpp PRE-CREATION
> src/common/validation.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55446/diff/
>
>
> Testing
> -------
>
> make check
> Tested with /r/55449/
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 55446: Added common validation for IDs.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55446/#review161426
-----------------------------------------------------------
src/common/validation.hpp (line 18)
<https://reviews.apache.org/r/55446/#comment232671>
Should this be `__COMMON_VALIDATION_HPP__`?
src/common/validation.hpp (line 34)
<https://reviews.apache.org/r/55446/#comment232672>
Since this is never used externally, consider making it a local static helper/
- James Peach
On Jan. 12, 2017, 9:46 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55446/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 9:46 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-6866
> https://issues.apache.org/jira/browse/MESOS-6866
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - The common validation logic is shared by the master and the agent.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c
> src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c
> src/common/validation.hpp PRE-CREATION
> src/common/validation.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55446/diff/
>
>
> Testing
> -------
>
> make check
> Tested with /r/55449/
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 55446: Added common validation for IDs.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55446/
-----------------------------------------------------------
(Updated Jan. 17, 2017, 5:37 p.m.)
Review request for mesos, Benjamin Mahler, James Peach, and Joseph Wu.
Changes
-------
Addressed comments.
Bugs: MESOS-6866
https://issues.apache.org/jira/browse/MESOS-6866
Repository: mesos
Description
-------
- The common validation logic is shared by the master and the agent.
Diffs (updated)
-----
src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c
src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c
src/common/validation.hpp PRE-CREATION
src/common/validation.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/55446/diff/
Testing
-------
make check
Tested with /r/55449/
Thanks,
Jiang Yan Xu