You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2016/03/02 18:20:00 UTC
[GitHub] flink pull request: [FLINK-3565] add module to force execution of ...
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1755
[FLINK-3565] add module to force execution of Shade plugin
This ensures that all properties of the root pom are properly
resolved by running the Shade plugin. Thus, our root pom does not have
to depend on a Scala version just because it holds the Scala version
properties.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3565
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1755
----
commit 47de08a9503da99b11fc45a7f299671ecab0b21e
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-03-02T16:52:05Z
[maven] add module to force execution of Shade plugin
This ensures that all properties of the root pom are properly
resolved by running the Shade plugin. Thus, our root pom does not have
to depend on a Scala version just because it holds the Scala version
properties.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3565] add module to force execution of ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1755
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3565] add module to force execution of ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1755#issuecomment-191343477
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3565] add module to force execution of ...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1755#issuecomment-191703337
The issue is that we use relative paths to JARs in the tests. The Shade plugin changes the working directory. Will provide a fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3565] add module to force execution of ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1755#issuecomment-191695544
The change breaks the tests: https://travis-ci.org/apache/flink/builds/113179846
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---