You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/22 04:29:56 UTC
Re: Review Request 45275: Enabled "--explicitcreate" when call "dvdcli
mount".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45275/
-----------------------------------------------------------
(Updated 四月 22, 2016, 2:29 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Summary (updated)
-----------------
Enabled "--explicitcreate" when call "dvdcli mount".
Bugs: MESOS-5251
https://issues.apache.org/jira/browse/MESOS-5251
Repository: mesos
Description (updated)
-------
Enabled "--explicitcreate" when call "dvdcli mount".
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp c63fa02b8f13014bbcac6984a49eaa919d26b489
Diff: https://reviews.apache.org/r/45275/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45275: Enabled "--explicitcreate" when call "dvdcli
mount".
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45275/#review130031
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45275]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 22, 2016, 2:29 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45275/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 2:29 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5251
> https://issues.apache.org/jira/browse/MESOS-5251
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled "--explicitcreate" when call "dvdcli mount".
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp c63fa02b8f13014bbcac6984a49eaa919d26b489
>
> Diff: https://reviews.apache.org/r/45275/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45275: Enabled "--explicitcreate" when call "dvdcli
mount".
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 22, 2016, 5:12 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp, lines 56-65
> > <https://reviews.apache.org/r/45275/diff/2/?file=1356192#file1356192line56>
> >
> > I think what we should do here is:
> >
> > 1) If 'options' is None, we add `--explicitcreate=true`
> >
> > 2) Otherwise, we don't
> >
> > 3) Added a TODO to check dvdcli version
One question for 1) and 2), why only add `--explicitcreate=true` when `options` is None? Why not always enable this parameter?
For 3), my thinking is that we only support version 0.2.0 which support the parameter of `--explicitcreate=true`, so the version checking logic will be if the version is not 0.2.0, return error.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45275/#review130125
-----------------------------------------------------------
On 四月 22, 2016, 2:29 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45275/
> -----------------------------------------------------------
>
> (Updated 四月 22, 2016, 2:29 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5251
> https://issues.apache.org/jira/browse/MESOS-5251
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled "--explicitcreate" when call "dvdcli mount".
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp c63fa02b8f13014bbcac6984a49eaa919d26b489
>
> Diff: https://reviews.apache.org/r/45275/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45275: Enabled "--explicitcreate" when call "dvdcli
mount".
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45275/#review130125
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp (lines 56 - 65)
<https://reviews.apache.org/r/45275/#comment193787>
I think what we should do here is:
1) If 'options' is None, we add `--explicitcreate=true`
2) Otherwise, we don't
3) Added a TODO to check dvdcli version
- Jie Yu
On April 22, 2016, 2:29 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45275/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 2:29 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5251
> https://issues.apache.org/jira/browse/MESOS-5251
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled "--explicitcreate" when call "dvdcli mount".
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp c63fa02b8f13014bbcac6984a49eaa919d26b489
>
> Diff: https://reviews.apache.org/r/45275/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>