Re: [PR] Enabling SegmentGenerationAndPushTask to push segment to realtime table [pinot]

["snleee (via GitHub)" <gi...@apache.org>]

snleee commented on code in PR #12084:
URL: https://github.com/apache/pinot/pull/12084#discussion_r1412844553


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java:
##########
@@ -1227,8 +1228,9 @@ public File downloadUntarFileStreamed(URI uri, File dest, AuthProvider authProvi
    * @return param list
    */
   public static List<NameValuePair> makeTableParam(String tableName) {
-    return Collections.singletonList(
-        new BasicNameValuePair(FileUploadDownloadClient.QueryParameters.TABLE_NAME, tableName));
+    return List.of(new BasicNameValuePair(FileUploadDownloadClient.QueryParameters.TABLE_NAME, tableName),

Review Comment:
   Can we do `FileUploadDownloadClient.QueryParameters.TABLE_NAME -> QueryParameters.TABLE_NAME` ?
   
   (I'm seeing that we use `QueryParameters.TABLE_TYPE` below)



##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/segmentgenerationandpush/SegmentGenerationAndPushTaskGenerator.java:
##########
@@ -106,18 +104,12 @@ public List<PinotTaskConfig> generateTasks(List<TableConfig> tableConfigs) {
     List<PinotTaskConfig> pinotTaskConfigs = new ArrayList<>();
 
     for (TableConfig tableConfig : tableConfigs) {
-      // Only generate tasks for OFFLINE tables
-      String offlineTableName = tableConfig.getTableName();
-      if (tableConfig.getTableType() != TableType.OFFLINE) {
-        LOGGER.warn("Skip generating SegmentGenerationAndPushTask for non-OFFLINE table: {}", offlineTableName);
-        continue;
-      }
-
+      String tableName = tableConfig.getTableName();

Review Comment:
   Let's change to `tableNameWithType`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org