You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2024/07/24 02:09:22 UTC
[PR] [SPARK-48986][CONNECT][SQL] Add ColumnNode Intermediate Representation [spark]
hvanhovell opened a new pull request, #47466:
URL: https://github.com/apache/spark/pull/47466
### What changes were proposed in this pull request?
This PR introduces an intermediate representation for Column operations. It also adds a converter from this IR to Catalyst Expression. This is a first step in sharing Column API between Classic and Connect. It is not integrated with any of the pre-existing code base.
### Why are the changes needed?
We want to share the Scala Column API between the Classic and Connect Scala DataFrame API implementations. For this we need to decouple the Column API from Catalyst.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
I added a test suite that tests the conversion from `ColumnNode` to `Expression`.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48986][CONNECT][SQL] Add ColumnNode Intermediate Representation [spark]
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #47466:
URL: https://github.com/apache/spark/pull/47466#issuecomment-2253073540
Merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48986][CONNECT][SQL] Add ColumnNode Intermediate Representation [spark]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #47466: [SPARK-48986][CONNECT][SQL] Add ColumnNode Intermediate Representation
URL: https://github.com/apache/spark/pull/47466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org